From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 13/23] drm: omapdrm: crtc: update plane fifos on lcd config change Date: Sat, 26 Mar 2016 19:00:53 +0200 Message-ID: <3716864.g0dovaDAJW@avalon> References: <1457455195-1938-1-git-send-email-sre@kernel.org> <1457455195-1938-14-git-send-email-sre@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1457455195-1938-14-git-send-email-sre@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sebastian Reichel Cc: Aaro Koskinen , Tony Lindgren , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org SGkgU2ViYXN0aWFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5IDA4IE1h ciAyMDE2IDE3OjM5OjQ1IFNlYmFzdGlhbiBSZWljaGVsIHdyb3RlOgo+IER1ZSB0byBhIGhhcmR3 YXJlIGJ1ZywgRklGT3MgdGhyZXNob2xkcyBtdXN0IGJlCj4gY29uZmlndXJlZCB2ZXJ5IGNhcmVm dWxseSBmb3IgbWFudWFsbHkgdXBkYXRlZAo+IGRpc3BsYXlzLgoKQ291bGQgeW91IHBsZWFzZSBw cm92aWRlIG1vcmUgaW5mb3JtYXRpb24gYWJvdXQgdGhlIGJ1ZyBhbmQgaG93IHRoZSBjb2RlIApo YW5kbGVzIGl0ID8KCj4gU2lnbmVkLW9mZi1ieTogU2ViYXN0aWFuIFJlaWNoZWwgPHNyZUBrZXJu ZWwub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2NydGMuYyB8IDQg KysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY3J0Yy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0v b21hcGRybS9vbWFwX2NydGMuYyBpbmRleCA4OTY3MDEzYzFmYjUuLjA5NGU4OWEyZmE5NAo+IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY3J0Yy5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9jcnRjLmMKPiBAQCAtMjUzLDYgKzI1MywxMCBA QCBzdGF0aWMgdm9pZCBvbWFwX2NydGNfZHNzX3NldF9sY2RfY29uZmlnKHN0cnVjdAo+IG9tYXBf b3ZlcmxheV9tYW5hZ2VyICptZ3IsIG9tYXBfY3J0Yy0+bWFudWFsbHlfdXBkYXRlZCA9Cj4gZHNz X2xjZF9tZ3JfY29uZmlnX2dldF9zdGFsbG1vZGUoY29uZmlnKTsKPiAKPiAgCWRpc3BjX21ncl9z ZXRfbGNkX2NvbmZpZyhvbWFwX2NydGMtPmNoYW5uZWwsIGNvbmZpZyk7Cj4gKwo+ICsJZHJtX2Zv cl9lYWNoX3BsYW5lKHBsYW5lLCBkZXYpIHsKPiArCQlvbWFwX3BsYW5lX3VwZGF0ZV9maWZvKHBs YW5lKTsKPiArCX0KClRoaXMgc2VlbXMgZmlzaHkgOi0vIFRvIHN0YXJ0IHdpdGggeW91IHNob3Vs ZG4ndCB0b3VjaCBwbGFuZXMgdGhhdCBkb24ndCAKYmVsb25nIHRvIHRoaXMgQ1JUQy4gVGhlbiwg dXBkYXRpbmcgdGhlIEZJRk8gdGhyZXNob2xkcyBoZXJlIGluIGFkZGl0aW9uIHRvIApvbWFwX3Bs YW5lX2F0b21pY191cGRhdGUoKSBtYWtlcyBtZSB3b25kZXIgaWYgYm90aCBhcmUgbmVlZGVkLCBh bmQgaWYgc28sIHdoeS4KCj4gIH0KPiAKPiAgc3RhdGljIGludCBvbWFwX2NydGNfZHNzX3JlZ2lz dGVyX2ZyYW1lZG9uZSgKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754750AbcC1TSO (ORCPT ); Mon, 28 Mar 2016 15:18:14 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:42866 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbcC1TSL (ORCPT ); Mon, 28 Mar 2016 15:18:11 -0400 From: Laurent Pinchart To: Sebastian Reichel Cc: Tony Lindgren , Aaro Koskinen , Tomi Valkeinen , David Airlie , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/23] drm: omapdrm: crtc: update plane fifos on lcd config change Date: Sat, 26 Mar 2016 19:00:53 +0200 Message-ID: <3716864.g0dovaDAJW@avalon> User-Agent: KMail/4.14.10 (Linux/4.1.15-gentoo-r1; KDE/4.14.16; x86_64; ; ) In-Reply-To: <1457455195-1938-14-git-send-email-sre@kernel.org> References: <1457455195-1938-1-git-send-email-sre@kernel.org> <1457455195-1938-14-git-send-email-sre@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, Thank you for the patch. On Tuesday 08 Mar 2016 17:39:45 Sebastian Reichel wrote: > Due to a hardware bug, FIFOs thresholds must be > configured very carefully for manually updated > displays. Could you please provide more information about the bug and how the code handles it ? > Signed-off-by: Sebastian Reichel > --- > drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c > b/drivers/gpu/drm/omapdrm/omap_crtc.c index 8967013c1fb5..094e89a2fa94 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_crtc.c > +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c > @@ -253,6 +253,10 @@ static void omap_crtc_dss_set_lcd_config(struct > omap_overlay_manager *mgr, omap_crtc->manually_updated = > dss_lcd_mgr_config_get_stallmode(config); > > dispc_mgr_set_lcd_config(omap_crtc->channel, config); > + > + drm_for_each_plane(plane, dev) { > + omap_plane_update_fifo(plane); > + } This seems fishy :-/ To start with you shouldn't touch planes that don't belong to this CRTC. Then, updating the FIFO thresholds here in addition to omap_plane_atomic_update() makes me wonder if both are needed, and if so, why. > } > > static int omap_crtc_dss_register_framedone( -- Regards, Laurent Pinchart