From: Thomas Monjalon <thomas@monjalon.net>
To: Gavin Li <gavinl@nvidia.com>
Cc: matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
dev@dpdk.org, rasland@nvidia.com, stable@dpdk.org
Subject: Re: [PATCH V2] net/mlx5: add support for flows targeting multicast MAC addresses
Date: Thu, 14 Aug 2025 16:05:36 +0200 [thread overview]
Message-ID: <3720215.hdfAi7Kttb@thomas> (raw)
In-Reply-To: <20250814100815.801132-1-gavinl@nvidia.com>
14/08/2025 12:08, Gavin Li:
> Rules for multicast MAC addresses are intended to filter multicast traffic
> and are managed through multicast MAC add/remove APIs. In mlx5_dev_spawn
> function, devices (PF, VFs, and SFs) retrieve the netdev-configured MAC
> addresses via netlink and store them in the PMD device data, which
> includes multicast MAC addresses.
>
> To update multicast MAC address rules, create them within
> mlx5_traffic_enable.
Sorry this is not clear.
Please explain what was the previous behaviour with a past tense,
and what is the new changed behaviour.
> BITFIELD_DECLARE(mac_own, uint64_t, MLX5_MAX_MAC_ADDRESSES);
> + BITFIELD_DECLARE(mac_pmd, uint64_t, MLX5_MAX_MAC_ADDRESSES);
Not sure about the naming.
What is the difference between mac_own and mac_pmd?
next prev parent reply other threads:[~2025-08-14 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 10:08 [PATCH V2] net/mlx5: add support for flows targeting multicast MAC addresses Gavin Li
2025-08-14 14:05 ` Thomas Monjalon [this message]
2025-08-15 1:55 ` Minggang(Gavin) Li
2025-08-16 21:33 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2025-08-15 11:43 Gavin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3720215.hdfAi7Kttb@thomas \
--to=thomas@monjalon.net \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=gavinl@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.