All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: linux-arm-kernel@lists.infradead.org, Hermann.Lauer@uni-heidelberg.de
Cc: wens@csie.org, mripard@kernel.org
Subject: Re: ARM: dts: sun7i: a20: bananapro: Fix ethernet node
Date: Thu, 21 Jan 2021 00:48:04 +0100	[thread overview]
Message-ID: <3722018.ZAFEQt6F9G@kista> (raw)
In-Reply-To: <20210120114026.GA3045@lemon.iwr.uni-heidelberg.de>

Hi!

Change itself it's fine, just few comments on your commit message and e-mail 
recipients.

Dne sreda, 20. januar 2021 ob 12:40:26 CET je Hermann.Lauer@uni-heidelberg.de 
napisal(a):
> BananaPro 1GB works only reliable with the patch for M2 Ultra applied to
> it's devicetree, too. Without this patch you will get high packet loss 
rates.

M2 Ultra has nothing to do with BananaPro, it's better to explain real reason 
why this change fixes ethernet.

> 
> Tested-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>

Tested-by tag from the patch author is not very useful, it's already expected 
that you (or person you know) tested it, when sending fixes.

> 
> From b3eec3212e66ece33f69be0de98d54e67834e798 Mon Sep 17 00:00:00 2001
> From: Jernej Skrabec <jernej.skrabec@siol.net>
> Date: Sun, 25 Oct 2020 09:19:49 +0100
> Subject: ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node

As I said, referencing fix for another, unrelated board is not really 
meaningful.

> 
> Ethernet PHY on BananaPi M2 Ultra provides RX and TX delays. Fix
> ethernet node to reflect that fact.
> 
> Fixes: c36fd5a48bd2 ("ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC 
ethernet controller")

Fixes tag is for M2 Ultra and completely irrelevant here. Please provide 
proper Fixes tag for this file.

You are missing Signed-of-by tag at the end of the message.

You missed few maintainers and mailing lists in "to" and "cc" field. Run 
"scripts/get_maintainer.pl" on this patch to get full list of recipients.

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-20 23:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 11:40 ARM: dts: sun7i: a20: bananapro: Fix ethernet node Hermann.Lauer
2021-01-20 23:48 ` Jernej Škrabec [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-01-20 11:07 Hermann.Lauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3722018.ZAFEQt6F9G@kista \
    --to=jernej.skrabec@siol.net \
    --cc=Hermann.Lauer@uni-heidelberg.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.