From: Thomas Monjalon <thomas@monjalon.net>
To: Nawal Kishor <nkishor@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Sachin Saxena <sachin.saxena@nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Jerin Jacob <jerinj@marvell.com>,
Ashwin Sekhar T K <asekhar@marvell.com>
Subject: Re: [PATCH] rawdev: fix device ID retrieval function prototype
Date: Thu, 16 Oct 2025 10:08:24 +0200 [thread overview]
Message-ID: <3733472.U7HbjWM52l@thomas> (raw)
In-Reply-To: <DS0PR18MB52705A2144204E371DDC6EC4B2E9A@DS0PR18MB5270.namprd18.prod.outlook.com>
16/10/2025 08:56, Nawal Kishor:
>
> >> Fixed rte_rawdev_get_dev_id() function prototype and its usage.
> >
> >What? Why?
>
> >[...]
> >> -uint16_t
> >> +int
> >> rte_rawdev_get_dev_id(const char *name);
>
> >Other functions handle dev_id as uint16_t, so why changing this function?
>
> The spec says that rte_rawdev_get_dev_id() returns negative number in case of failure.
> But in the definition it is returning uint16_t which will never be negative, hence changed it to int.
>
> If this is not acceptable, what fix will you suggest?
You should change to int16_t for all rawdev id parameters.
next prev parent reply other threads:[~2025-10-16 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 5:56 [PATCH] rawdev: fix device ID retrieval function prototype Nawal Kishor
2025-10-15 15:05 ` Thomas Monjalon
2025-10-16 6:56 ` Nawal Kishor
2025-10-16 8:08 ` Thomas Monjalon [this message]
2025-10-17 11:05 ` [EXTERNAL] " Akhil Goyal
2025-10-17 15:52 ` Thomas Monjalon
2025-10-19 10:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3733472.U7HbjWM52l@thomas \
--to=thomas@monjalon.net \
--cc=asekhar@marvell.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=nkishor@marvell.com \
--cc=sachin.saxena@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.