From: richard@nod.at (Richard Weinberger)
To: linux-mtd@lists.infradead.org
Subject: [PATCH] ubi: account the fastmap data blocks when checking found_pebs
Date: Wed, 16 Jan 2019 10:17:31 +0100 [thread overview]
Message-ID: <3735706.oOp81Q8WGZ@blindfold> (raw)
In-Reply-To: <a540ab38-c0a9-1339-7c1c-23008b375b71@huawei.com>
Tao,
Am Mittwoch, 16. Januar 2019, 10:12:47 CET schrieb Hou Tao:
> > This should get accounted in the loop above.
> > list_for_each_entry(aeb, &ai->fastmap, u.list) {
> >
> I have considered to add these data blocks into the fastmap list in ubi_scan_fastmap(), but
> it seems nobody will try to find the data block in fastmap list, so I choose a quick fix for
> the assertion.
Please fix it properly. Fastmap is already a way too complicated.
BTW: What NAND is this? How many blocks does fastmap need?
Usually on huge NANDs the whole fastmap fits into one block.
> > I agree that this logic needs a redesign.
> > Please see this patch series I sent last year but had no time to further work
> > on it:
> > https://lkml.org/lkml/2018/6/13/755
> >
> > I'd highly appreciate if you could revive it. :-)
> >
> Do you mean the whole patch set ? And we are planning to enable fast-map in our products,
> so I could try to do it.
The more the merrier. :)
Thanks,
//richard
next prev parent reply other threads:[~2019-01-16 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 0:59 [PATCH] ubi: account the fastmap data blocks when checking found_pebs Hou Tao
2019-01-16 8:00 ` Richard Weinberger
2019-01-16 9:12 ` Hou Tao
2019-01-16 9:17 ` Richard Weinberger [this message]
2019-01-16 9:38 ` Hou Tao
2019-01-16 9:43 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3735706.oOp81Q8WGZ@blindfold \
--to=richard@nod.at \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.