From: Thomas Monjalon <thomas@monjalon.net>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com, chas3@att.com,
ferruh.yigit@intel.com, arybchenko@solarflare.com
Subject: Re: [PATCH v2] net/bonding: fix segfault when creating bonded device
Date: Wed, 31 Oct 2018 17:11:19 +0100 [thread overview]
Message-ID: <3736462.5cob8yss4D@xps> (raw)
In-Reply-To: <1541001008-13498-1-git-send-email-radu.nicolau@intel.com>
31/10/2018 16:50, Radu Nicolau:
> After the patch below the call to rte_eth_bond_8023ad_agg_selection_set
> from probe() segfaults; there is no need to call the function, just set
> the mode directly.
> Also, reverted 1620175b400e.
>
> Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing")
> Fixes: 1620175b400e ("net/bonding: fix invalid port id")
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
I cannot ack because I do not master this PMD,
but it looks good to me.
next prev parent reply other threads:[~2018-10-31 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 13:59 [PATCH] net/bonding: fix segfault when creating bonded device Radu Nicolau
2018-10-31 15:06 ` Thomas Monjalon
2018-10-31 15:34 ` Radu Nicolau
2018-10-31 15:37 ` Chas Williams
2018-10-31 15:44 ` Thomas Monjalon
2018-10-31 15:50 ` [PATCH v2] " Radu Nicolau
2018-10-31 16:11 ` Thomas Monjalon [this message]
2018-10-31 16:14 ` Chas Williams
2018-11-02 20:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3736462.5cob8yss4D@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.