Re: [PATCH v5 0/6] drm/i915/selftests: Modernize printing in i915 selftests

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 01 Oct 2026, Krzysztof Karas <krzysztof.karas@intel.com> wrote:
> Currently, in many instances, i915 functions call pr_* macros
> to write a message to the system log. This way of printing
> lacks device context, which could be a valuable source of
> information. Many files in DRM already use drm_* prints to
> include that context, so it would be beneficial to do the same
> for i915 as well. Start small and convert i915 selftests first.
>
> v5:
>  * Reverted adding i915_* family of print macros (Jani, Andi);

On this version of the series,

Acked-by: Jani Nikula <jani.nikula@intel.com>

There are a few nitpicks, I might reply inline about them, but let's
just get this merged and over with, and *maybe* we can look at them
afterwards. Or not.

BR,
Jani.


>
> Krzysztof Karas (6):
>   drm/i915/selftests: Use gt_*/drm_* prints in core selftests
>   drm/i915/selftests: Use gt_*/drm_* prints in selftest helpers
>   drm/i915/gt/selftests: Use gt_* prints in aggregated gt selftests
>   drm/i915/gt/selftests: Use gt_* prints in gt standalone tests
>   drm/i915/gt/selftests: Use gt_* prints in gt selftest helpers
>   drm/i915/selftests: Use drm_* prints in i915_selftest.c
>
>  drivers/gpu/drm/i915/gt/selftest_context.c    |  20 +-
>  drivers/gpu/drm/i915/gt/selftest_engine_cs.c  |   5 +-
>  .../drm/i915/gt/selftest_engine_heartbeat.c   |   7 +-
>  drivers/gpu/drm/i915/gt/selftest_engine_pm.c  |  31 ++-
>  drivers/gpu/drm/i915/gt/selftest_execlists.c  | 243 +++++++++++-------
>  drivers/gpu/drm/i915/gt/selftest_gt_pm.c      |  21 +-
>  drivers/gpu/drm/i915/gt/selftest_llc.c        |  25 +-
>  drivers/gpu/drm/i915/gt/selftest_migrate.c    |  47 ++--
>  drivers/gpu/drm/i915/gt/selftest_mocs.c       |   7 +-
>  drivers/gpu/drm/i915/gt/selftest_rc6.c        |  32 ++-
>  drivers/gpu/drm/i915/gt/selftest_reset.c      |  20 +-
>  drivers/gpu/drm/i915/gt/selftest_rps.c        | 126 +++++----
>  drivers/gpu/drm/i915/gt/selftest_slpc.c       |  79 ++++--
>  drivers/gpu/drm/i915/gt/selftest_tlb.c        |  24 +-
>  .../gpu/drm/i915/gt/selftest_workarounds.c    |  70 +++--
>  drivers/gpu/drm/i915/selftests/i915_active.c  |  12 +-
>  .../gpu/drm/i915/selftests/i915_gem_evict.c   |  52 ++--
>  drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 164 ++++++++----
>  drivers/gpu/drm/i915/selftests/i915_perf.c    |  30 ++-
>  drivers/gpu/drm/i915/selftests/i915_request.c | 206 +++++++++------
>  .../gpu/drm/i915/selftests/i915_selftest.c    |  10 +-
>  drivers/gpu/drm/i915/selftests/i915_vma.c     | 187 +++++++++-----
>  .../gpu/drm/i915/selftests/igt_flush_test.c   |   4 +-
>  .../gpu/drm/i915/selftests/igt_live_test.c    |   6 +-
>  drivers/gpu/drm/i915/selftests/igt_reset.c    |   4 +-
>  .../i915/selftests/intel_scheduler_helpers.c  |   7 +-
>  drivers/gpu/drm/i915/selftests/intel_uncore.c |  24 +-
>  .../gpu/drm/i915/selftests/mock_gem_device.c  |   4 +-
>  28 files changed, 958 insertions(+), 509 deletions(-)

-- 
Jani Nikula, Intel