From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sven@narfation.org>
From: Sven Eckelmann <sven@narfation.org>
Date: Tue, 19 Mar 2019 08:48:23 +0100
Message-ID: <3741851.odfRDC6XPo@bentobox>
In-Reply-To: <20190214155243.10207-1-linus.luessing@c0d3.blue>
References: <20190214155243.10207-1-linus.luessing@c0d3.blue>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1662782.6hVt7tHVo5";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: allow updating DAT entry
 timeouts on incoming ARP Replies
List-Id: The list for a Better Approach To Mobile Ad-hoc Networking
 <b.a.t.m.a.n.lists.open-mesh.org>
List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe>
List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/>
List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org>
List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help>
List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Linus =?ISO-8859-1?Q?L=FCssing?= <linus.luessing@c0d3.blue>, Daniel Ehlers <sargon@toppoint.de>, Antonio Quartulli <a@unstable.cc>

--nextPart1662782.6hVt7tHVo5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Thursday, 14 February 2019 16:52:43 CET Linus L=FCssing wrote:
> Currently incoming ARP Replies, for example via a DHT-PUT message, do
> not update the timeout for an already existing DAT entry. These ARP
> Replies are dropped instead.
>=20
> This however defeats the purpose of the DHCPACK snooping, for instance.
> Right now, a DAT entry in the DHT will be purged every five minutes,
> likely leading to a mesh-wide ARP Request broadcast after this timeout.
> Which then recreates the entry. The idea of the DHCPACK snooping is to
> be able to update an entry before a timeout happens, to avoid ARP Request
> flooding.
>=20
> This patch fixes this issue by updating a DAT entry on incoming
> ARP Replies even if a matching DAT entry already exists. While still
> filtering the ARP Reply towards the soft-interface, to avoid duplicate
> messages on the client device side.
>=20
> Signed-off-by: Linus L=FCssing <linus.luessing@c0d3.blue>
> ---
>=20
> This patch was verified in VMs via gratuitous ARP Replies generated by
> "mausezahn", together with the
> "batman-adv: allow snooping gratuitous ARP Replies" patch.
>=20
> Before this patch, the timeout observed via "batctl dc" would continue
> to increase on gratuitous ARP Reply reception. After this patch, the
> last-seen value was reset to 0 successfully.
> ---


@Antonio: Any opinions about the patch [1]?

Kind regards,
	Sven

[1] https://patchwork.open-mesh.org/patch/17828/
--nextPart1662782.6hVt7tHVo5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlyQnscACgkQXYcKB8Em
e0ZztRAAsQ6/znf2xUubDUBzbQVxSohdiKTyS2X5WUR7tQ+ococMzEMK6s/sOg3Q
Ez1Y0InqROveRBNclrfTVDB8FcAvNMc5lhapBBWREA6mFItGMugkRspKalCcUnb+
dnEc9845z3DXlB2Jhvoy+0Z+8wGe+Tin9CpRgn04XIWA9MxTM5UvNBs4Kq7ffKir
j1lx+yDmHabGO7ZvLPOpwZZldCAheXFQZTJBsMpJ9/mu38/p0RIseMFtWFybHnDA
iLCkZRYH1ifhhWPsZjCPq2BlcYx3x8VWN0U21Ohl9lLo5VFJvOfLvlH0Vt0KFDSM
jYTZqsWPqiLsbI0J0dnFDQyWvHD/ij/+3Kfw9VtqKLCYBr3k6qjYiVaSkSxDyxuB
tiXYC0r5pWEBMGnskm0rdwPMo0ioQKc9Z2JQEIDuwMf9jVwE0puZLrG3atZG7gtF
REg1yinawngXoAILyZrsU2SmD07XQIumVe/iq6aQ58ChLgm0D4UrnmqX1f7sY2FE
2OK/iqDTsOYBmONbUkPlxhmj0f3KsuxPfbenA9nUVKT8jntz80L5jVghy4jO6Cd8
gMCBg4uAiO/6QSCcp2uzSJ/UdOAURBopiHZFkcK2rUX1xI2W1KgUHynKO1Zvcw3g
erYN2iyNXbGCIHusmO52P73N3BnCaAeebSMhJyHCSxtTKrxWfcw=
=0bUQ
-----END PGP SIGNATURE-----

--nextPart1662782.6hVt7tHVo5--