From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4586336E49D for ; Fri, 6 Mar 2026 10:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772794335; cv=none; b=DS/ah12ohMHFZ34pMx+5zHO1rJbG5D6pLFJp76BBB8vrdrtno0GiRwuFoSzz3Ipqp1X/0+VLsdde+llVnSjQzSl+FY9jq1xXpMWAoziDt4KzBwRbB8sUhQYXa81bvRZp9WjGiMBi5QwqoSwiVCRE9qg82RumOQarBKzz4bXnZyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772794335; c=relaxed/simple; bh=z87XzOv4holHp8moQ6B2iNBKmHotGCtKyqh2FtPJgBU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZLfHH5+WWcvh+p3Vus37qJQF63Xe8zfxRtZxITIol0ILAILwFG2lyeIdOGq6eXj5obZpiUhEsHidxfnFBHrjX3T0VCgBymUyfXjcW1AiYC7cb2Sad0kSTcbJaP8k05Skcc7Yrr4vg2v9Nq000N2hCRyedLpYar0CDOcIv7yPZu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=kiW8/+LU; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="kiW8/+LU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=z87XzOv4holHp8moQ6B2iNBKmHotGCtKyqh2FtPJgBU=; b=kiW8/+LUHH2XugnqErUsbIIF0o A2dFUWHizPpuMlDsRXzQS8ZeMPyP6YCM+piQ872Jrm6T9ujfs5Il7t83KefVt3kkbR4glqedAtDGU 023Dl7TL1UE5wEuFl4O8H1kmpaUpOT27fwOpQ78quObcDFljYiE7uwufBE3qnG1aGLclXeifqDTHe TW8V8gz+g9JYJ54HPOHgyP6QeUbjeHto4rS5MhPNzosWfLc1VBuYwQFLiJX2HTZcCN7aID/9qTFi+ ByJtJe33wE+Y56Qxdva9+Oni6nvmHlXSZNQE5IwkDalIj39w1wE96eOlXt54SgFp0p6okNAcFGde0 aZQMrQVg==; From: Heiko Stuebner To: Stephen Boyd , Shawn Lin Cc: linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, Shawn Lin Subject: Re: [PATCH] clk: rockchip: rk3568: Add PCIe pipe clock gates Date: Fri, 06 Mar 2026 11:52:06 +0100 Message-ID: <3742329.R56niFO833@phil> In-Reply-To: <1772698011-145625-1-git-send-email-shawn.lin@rock-chips.com> References: <1772698011-145625-1-git-send-email-shawn.lin@rock-chips.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Shawn, Am Donnerstag, 5. M=C3=A4rz 2026, 09:06:51 Mitteleurop=C3=A4ische Normalzei= t schrieb Shawn Lin: > The PCIe pipe clocks are currently left as orphan clocks and remain > enabled indefinitely, which is suboptimal. Add the missing clock gates > so the PCIe driver can explicitly manage them when not in use. >=20 > Signed-off-by: Shawn Lin > --- > Hi Heiko, >=20 > This patch should be considered only after David's patch[1] is merged, > otherwise it breaks PCIe on RK3566/RK3568 due to clk_disable_unused(). This would also break compatiblity with old devicetrees. The devicetree used by the kernel can also be embedded for example in an already installed u-boot and handed to the kernel from there. You cannot expect board devicetrees and the kernel image to be updated in lockstep. We also sort of guarantee this backwards compatiblity - old DTB with newer kernel. The solution is to add a CLK_IGNORE_UNUSED flag (but not CLK_IS_CRITICAL) to the newly added gate. This lets the clock stay and keeps the original behavious on old DTBs, but also allows the PCIe driver in newer kernels to turn off the clock if it wants to. Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFAA5F01826 for ; Fri, 6 Mar 2026 10:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lym4MSRPkdjmEmxFZznmkNbGQcx2igB5QxxMH8A4PKQ=; b=fOHc2zOvF7UPAJ 37NkCOLJWOqDmhqeStq4o+VkbEYIXmWT26yPOLAM3PUsnouDBfomgKMB60HFwuuChn4qrDc/hzF2+ kYfm1rkfDx0FxZxEX/i0EKg2SfoswwK5GEuV/Bqubjx47HZi1W4iOBufFOsiAY1E5iqnPq68buGzt N6wfsQx207F/0FnMThFNDgsjlYeissHjxmT7tb0BNM8aiN4WIVxpan6kPYIsFLhFAhj233RmMs+iJ +vnYdUafT3u7UXTFV7lp7iWD4iTj/6cY9XHU9EIOKX5oCINhSvtL50/kaBW/xdw/UUVrZha6GivVQ DDrifAf/I6Y1KMFN+0dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vySmx-00000003Vv2-1Izm; Fri, 06 Mar 2026 10:52:11 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vySmv-00000003Vth-1g6V for linux-rockchip@lists.infradead.org; Fri, 06 Mar 2026 10:52:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=z87XzOv4holHp8moQ6B2iNBKmHotGCtKyqh2FtPJgBU=; b=kiW8/+LUHH2XugnqErUsbIIF0o A2dFUWHizPpuMlDsRXzQS8ZeMPyP6YCM+piQ872Jrm6T9ujfs5Il7t83KefVt3kkbR4glqedAtDGU 023Dl7TL1UE5wEuFl4O8H1kmpaUpOT27fwOpQ78quObcDFljYiE7uwufBE3qnG1aGLclXeifqDTHe TW8V8gz+g9JYJ54HPOHgyP6QeUbjeHto4rS5MhPNzosWfLc1VBuYwQFLiJX2HTZcCN7aID/9qTFi+ ByJtJe33wE+Y56Qxdva9+Oni6nvmHlXSZNQE5IwkDalIj39w1wE96eOlXt54SgFp0p6okNAcFGde0 aZQMrQVg==; From: Heiko Stuebner To: Stephen Boyd , Shawn Lin Cc: linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, Shawn Lin Subject: Re: [PATCH] clk: rockchip: rk3568: Add PCIe pipe clock gates Date: Fri, 06 Mar 2026 11:52:06 +0100 Message-ID: <3742329.R56niFO833@phil> In-Reply-To: <1772698011-145625-1-git-send-email-shawn.lin@rock-chips.com> References: <1772698011-145625-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260306_025209_446318_CE1F2285 X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgU2hhd24sCgpBbSBEb25uZXJzdGFnLCA1LiBNw6RyeiAyMDI2LCAwOTowNjo1MSBNaXR0ZWxl dXJvcMOkaXNjaGUgTm9ybWFsemVpdCBzY2hyaWViIFNoYXduIExpbjoKPiBUaGUgUENJZSBwaXBl IGNsb2NrcyBhcmUgY3VycmVudGx5IGxlZnQgYXMgb3JwaGFuIGNsb2NrcyBhbmQgcmVtYWluCj4g ZW5hYmxlZCBpbmRlZmluaXRlbHksIHdoaWNoIGlzIHN1Ym9wdGltYWwuIEFkZCB0aGUgbWlzc2lu ZyBjbG9jayBnYXRlcwo+IHNvIHRoZSBQQ0llIGRyaXZlciBjYW4gZXhwbGljaXRseSBtYW5hZ2Ug dGhlbSB3aGVuIG5vdCBpbiB1c2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogU2hhd24gTGluIDxzaGF3 bi5saW5Acm9jay1jaGlwcy5jb20+Cj4gLS0tCj4gSGkgSGVpa28sCj4gCj4gVGhpcyBwYXRjaCBz aG91bGQgYmUgY29uc2lkZXJlZCBvbmx5IGFmdGVyIERhdmlkJ3MgcGF0Y2hbMV0gaXMgbWVyZ2Vk LAo+IG90aGVyd2lzZSBpdCBicmVha3MgUENJZSBvbiBSSzM1NjYvUkszNTY4IGR1ZSB0byBjbGtf ZGlzYWJsZV91bnVzZWQoKS4KClRoaXMgd291bGQgYWxzbyBicmVhayBjb21wYXRpYmxpdHkgd2l0 aCBvbGQgZGV2aWNldHJlZXMuCgpUaGUgZGV2aWNldHJlZSB1c2VkIGJ5IHRoZSBrZXJuZWwgY2Fu IGFsc28gYmUgZW1iZWRkZWQgZm9yIGV4YW1wbGUKaW4gYW4gYWxyZWFkeSBpbnN0YWxsZWQgdS1i b290IGFuZCBoYW5kZWQgdG8gdGhlIGtlcm5lbCBmcm9tIHRoZXJlLgpZb3UgY2Fubm90IGV4cGVj dCBib2FyZCBkZXZpY2V0cmVlcyBhbmQgdGhlIGtlcm5lbCBpbWFnZSB0byBiZSB1cGRhdGVkCmlu IGxvY2tzdGVwLgoKV2UgYWxzbyBzb3J0IG9mIGd1YXJhbnRlZSB0aGlzIGJhY2t3YXJkcyBjb21w YXRpYmxpdHkgLSBvbGQgRFRCIHdpdGgKbmV3ZXIga2VybmVsLgoKVGhlIHNvbHV0aW9uIGlzIHRv IGFkZCBhIENMS19JR05PUkVfVU5VU0VEIGZsYWcgKGJ1dCBub3QgQ0xLX0lTX0NSSVRJQ0FMKQp0 byB0aGUgbmV3bHkgYWRkZWQgZ2F0ZS4KClRoaXMgbGV0cyB0aGUgY2xvY2sgc3RheSBhbmQga2Vl cHMgdGhlIG9yaWdpbmFsIGJlaGF2aW91cyBvbiBvbGQgRFRCcywKYnV0IGFsc28gYWxsb3dzIHRo ZSBQQ0llIGRyaXZlciBpbiBuZXdlciBrZXJuZWxzIHRvIHR1cm4gb2ZmIHRoZSBjbG9jawppZiBp dCB3YW50cyB0by4KClRoYW5rcwpIZWlrbwoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJv Y2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo=