From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Ori Kam <orika@nvidia.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
david.marchand@redhat.com, aconole@redhat.com
Subject: Re: [dpdk-dev] [PATCH v3] ethdev: replace bit shifts with macros
Date: Thu, 07 Oct 2021 16:11:35 +0200 [thread overview]
Message-ID: <3749057.Eksa6WUJdZ@thomas> (raw)
In-Reply-To: <20211007132700.452945-1-thomas@monjalon.net>
07/10/2021 15:26, Thomas Monjalon:
> The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts.
> The macro UINT64C is also used to replace remaining occurrences of ULL.
>
> Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason.
>
> The API of rte_mtr and rte_tm is using enums for 64-bit variables.
> As they are enums, RTE_BIT32 is used.
> The corresponding struct members should be converted to 32-bit.
According to this report:
http://mails.dpdk.org/archives/test-report/2021-October/224792.html
Ubuntu 18.04 does not accept this change:
rte_tm.h:181:2: error: enumerator value for ‘RTE_TM_UPDATE_NODE_ADD_DELETE’
is not an integer constant
RTE_TM_UPDATE_NODE_ADD_DELETE = RTE_BIT32(2),
Anybody understands why?
next prev parent reply other threads:[~2021-10-07 14:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 21:04 [dpdk-dev] [PATCH] ethdev: replace bit shifts with macros Thomas Monjalon
2021-09-16 6:52 ` Andrew Rybchenko
2021-09-16 8:55 ` Thomas Monjalon
2021-09-16 9:36 ` Andrew Rybchenko
2021-09-23 9:39 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2021-10-05 19:18 ` Thomas Monjalon
2021-10-07 10:07 ` Andrew Rybchenko
2021-10-07 11:07 ` Ferruh Yigit
2021-10-07 13:26 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-10-07 14:11 ` Thomas Monjalon [this message]
2021-10-07 15:48 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2021-10-07 17:32 ` Ferruh Yigit
2021-10-07 18:29 ` Thomas Monjalon
2021-10-13 7:52 ` [dpdk-dev] [PATCH v5] " Thomas Monjalon
2021-10-13 11:29 ` Ferruh Yigit
2021-10-20 14:55 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-10-20 17:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3749057.Eksa6WUJdZ@thomas \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=orika@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.