From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Martin Hundebøll" <martin@hundeboll.net>,
"Sven Eckelmann" <sven@narfation.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 1/2] batman-adv: Check total_size when queueing fragments
Date: Sun, 11 Jan 2015 18:27:49 +0800 [thread overview]
Message-ID: <3750988.JXPdiNAa4Q@diderot> (raw)
In-Reply-To: <547C534E.5010405@hundeboll.net>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Monday 01 December 2014 12:38:54 Martin Hundebøll wrote:
> On 2014-12-01 10:37, Sven Eckelmann wrote:
> > The fragmentation code was replaced in
> > 9b3eab61754d74a93c9840c296013fe3b4a1b606 ("batman-adv: Receive fragmented
> > packets and merge") by an implementation which handles the
> > queueing+merging of fragments based on their size and the total_size of
> > the non-fragmented packet. This total_size is announced by each fragment.
> > The new implementation doesn't check if the the total_size information of
> > the packets inside one chain is consistent.
> >
> > This is consistency check is recommended to allow using any of the packets
> > in the queue to decide whether all fragments of a packet are received or
> > not.
> >
> > Signed-off-by: Sven Eckelmann <sven@narfation.org>
>
> As with the first version:
> Acked-by: Martin Hundebøll <martin@hundeboll.net>
Applied in revision 73c9ecc.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-01-11 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 9:37 [B.A.T.M.A.N.] [PATCHv3 1/2] batman-adv: Check total_size when queueing fragments Sven Eckelmann
2014-12-01 9:37 ` [B.A.T.M.A.N.] [PATCHv3 2/2] batman-adv: Use only queued fragments when merging Sven Eckelmann
2014-12-01 11:40 ` Martin Hundebøll
2015-01-11 10:29 ` Marek Lindner
2014-12-01 11:38 ` [B.A.T.M.A.N.] [PATCHv3 1/2] batman-adv: Check total_size when queueing fragments Martin Hundebøll
2015-01-11 10:27 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3750988.JXPdiNAa4Q@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=martin@hundeboll.net \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.