From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH]i40e: move the fdir_setup from dev_init to dev_configure Date: Fri, 05 Dec 2014 17:13:58 +0100 Message-ID: <3752546.1FjpsJa7G7@xps13> References: <1417707623-25777-1-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Wu, Jingjing" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > In order not to affect the FVL's performance by default setting, this patch moves > > the flow director initialization from i40e_pf_setup to i40e_dev_configure > > according to the mode in fdir configure info. > > Then the resources used for flow director will be only setup if it is enabled. > > > > Signed-off-by: jingjing.wu > > Acked-by: Helin Zhang Applied A lot of commit titles need rewording. This one is a good example to explain. We don't need to see the function or structure names in a title. The global idea is a lot more interesting and easy to read. Here, I changed i40e: move the fdir_setup from dev_init to dev_configure to i40e: setup flow director only if enabled Thanks -- Thomas