From mboxrd@z Thu Jan 1 00:00:00 1970 From: Janusz Krzysztofik Subject: Re: [PATCH v3 00/15] ASoC: OMAP: Convert to use dmaengine Date: Sat, 15 Sep 2012 23:38:32 +0200 Message-ID: <3759862.8IETAs1y1n@acer> References: <1347624358-25582-1-git-send-email-peter.ujfalusi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from d1.icnet.pl (d1.icnet.pl [212.160.220.21]) by alsa0.perex.cz (Postfix) with ESMTP id 7A4432602DC for ; Sat, 15 Sep 2012 23:40:58 +0200 (CEST) In-Reply-To: <1347624358-25582-1-git-send-email-peter.ujfalusi@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: Lars-Peter Clausen , Tony Lindgren , Ricardo Neri , Mark Brown , linux-kernel@vger.kernel.org, Peter Ujfalusi , Vinod Koul , linux-arm-kernel@lists.infradead.org, Dan Williams , Russell King , linux-omap@vger.kernel.org, Liam Girdwood , Jarkko Nikula List-Id: alsa-devel@alsa-project.org RG5pYSBwacSFdGVrLCAxNCB3cnplxZtuaWEgMjAxMiAxNTowNTo0MyBQZXRlciBVamZhbHVzaSBw aXN6ZToKPiBIZWxsbywKPiAKPiBDaGFuZ2VzIHNpbmNlIHYyOgo+IC0gQXMgaXQgaGFzIGJlZW4g ZGlzY3Vzc2VkIHRoZSBub193YWtldXAgcGFyYW1ldGVyIGhhcyBiZWVuIHJlcGxhY2VkIHdpdGgg ZmxhZ3MKPiAgIGZvciB0aGUgZG1hZW5naW5lIEFQSXMKPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+ IC0gU3VwcG9ydCBmb3IgcGF1c2UvcmVzdW1lIGZvciBPTUFQIGF1ZGlvIHZpYSBkbWFlbmdpbmUK PiAtIGRtYWVuZ2luZTogc3VwcG9ydCBmb3IgTk9fUEVSSU9EX1dBS0VVUCBpbiBjeWNsaWMgbW9k ZQo+ICAtIE9NQVAgdG8ga2VlcCBzdXBwb3J0aW5nIE5PX1BFUklPRF9XQUtFVVAgZm9yIGF1ZGlv Cj4gIC0gT3RoZXIgcGxhZm9ybXMgY2FuIGFsc28gdHJ5IHRvIGVuYWJsZSB0aGlzIG1vZGUgc2lu Y2Ugd2UgaGF2ZSBub3cgZ2VuZXJpYwo+ICAgIGludGVyZmFjZSB0byBkbyBzby4KPiAKPiBUaGlz IHNlcmllcyB3aWxsIHN3aXRjaCB0aGUgT01BUCBhdWRpbyB0byB1c2UgZG1hZW5naW5lLgo+IFRo ZSBmaW5hbCBwYXRjaCB3aGljaCBkb2VzIHRoZSBzd2l0Y2ggd2FzIGJhc2VkIG9uIFJ1c3NlbGwg S2luZydzIGVhcmxpZXIgcGF0Y2guCj4gCj4gVGhlIGZpcnN0IDEwIHBhdGNoIGlzIHRvIHByZXBh cmUgdGhlIE9NQVAgYXVkaW8gZHJpdmVycyBmb3IgYSBzbW9vdGggY2hhbmdlIHRvCj4gZG1hZW5n aW5lOgo+IC0gc0RNQSBGUkFNRSBzeW5jIG1vZGUgaXMgcmVtb3ZlZCBhbmQgcmVwbGFjZWQgd2l0 aCBQQUNLRVQgbW9kZQo+IC0gZGFpIGRyaXZlcnMgbm8gbG9uZ2VyIG5lZWQgdG8gY29uZmlndXJl IHNETUEgc3luYyBtb2RlCj4gLSBkYWkgZHJpdmVycyBkb2VzIG5vdCBuZWVkIHRvIHNwZWNpZnkg dGhlIERNQSB3b3JkIGxlbmd0aCAtIHdpdGggdGhlIGV4Y2VwdGlvbgo+ICAgb2YgdGhlIG9tYXAt aGRtaSBkcml2ZXIgd2hpY2ggcmVxdWlyZXMgMzJiaXQgd29yZCBsZW5ndGggcmVnYXJkbGVzcyBv ZiB0aGUKPiAgIGF1ZGlvIGZvcm1hdCBpbiB1c2UKPiAtIHRoZSBNY1BETSBkcml2ZXIgdXNlZCAo dG8gbXkgc3VycHJpc2UpIGhhY2tpc2ggd2F5IG9mIGdldHRpbmcgdGhlIERNQSBjaGFubmVsCj4g ICBhbmQgYWRkcmVzcyAtIHZpYSBkZWZpbmVzIGZyb20gc29tZSBoZWFkZXIgZmlsZXMKPiAKPiBB ZnRlciB0aGUgY29udmVyc2lvbiBPTUFQIGF1ZGlvIHN1cHBvcnQgc2hvdWxkIGhhdmUgdGhlIHNh bWUgZmVhdHVyZXMgYXMgYmVmb3JlLAo+IG5vIHJlZ3Jlc3Npb25zIGV4cGVjdGVkLgo+IAo+IEkg aGF2ZSB0ZXN0ZWQgdGhlIHNlcmllcyBvbjoKPiAtIEJlYWdsZUJvYXJkIChhdWRpbyB2aWEgTWNC U1ApOiAKPiAgLSBhcGxheS9hcmVjb3JkLiBJbiBlbGVtZW50IG1vZGUgYW5kIGluIHRocmVzaG9s ZCBtb2RlIHdpdGggZGlmZmVyZW50IHBlcmlvZAo+ICAgIHNpemVzCj4gIC0gbXBsYXllciAtYW8g YWxzYTogZm9yIGRpcmVjdCBBTFNBIGFjY2Vzcwo+ICAtIG1wbGF5ZXIgLWFvIHB1bHNlOiB2aWEg UHVsc2VBdWRpbyB0byB0ZXN0IE5PX1BFUklPRF9XQUtFVVAgZmVhdHVyZQo+IC0gT01BUDQgQmxh emUgKGF1ZGlvIHZpYSBNY1BETSBhbmQgRE1JQykKPiAgLSBhcGxheS9hcmVjb3JkCj4gIC0gbXBs YXllciAtYW8gYWxzYTogZm9yIGRpcmVjdCBBTFNBIGFjY2Vzcwo+ICAtIG1wbGF5ZXIgLWFvIHB1 bHNlOiB2aWEgUHVsc2VBdWRpbyB0byB0ZXN0IE5PX1BFUklPRF9XQUtFVVAgZmVhdHVyZQo+IAo+ IFRoZSBwYXRjaGVzIGhhcyBiZWVuIGdlbmVyYXRlZCBhZ2FpbnN0Ogo+IGdpdDovL2dpdC5rZXJu ZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9icm9vbmllL3NvdW5kLmdpdCBmb3ItMy43 Cj4gCj4gSmFudXN6OiBDYW4geW91IHJldGVzdCB0aGlzIHNlcmllcyBvbiBPTUFQMSB0byBiZSBz dXJlIEkgaGF2ZSBub3QgYnJva2VuIGl0PwoKSGkgUGV0ZXIsCkl0IGxvb2tzIGxpa2UgeW91IGhh dmVuJ3QgOi0pLgoKRm9yIE9NQVAxOgpUZXN0ZWQtYnk6IEphbnVzeiBLcnp5c3p0b2ZpayA8amty enlzenRAdGlzLmljbmV0LnBsPgoKVGhhbmtzLApKYW51c3oKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1k ZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFp bG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: jkrzyszt@tis.icnet.pl (Janusz Krzysztofik) Date: Sat, 15 Sep 2012 23:38:32 +0200 Subject: [alsa-devel] [PATCH v3 00/15] ASoC: OMAP: Convert to use dmaengine In-Reply-To: <1347624358-25582-1-git-send-email-peter.ujfalusi@ti.com> References: <1347624358-25582-1-git-send-email-peter.ujfalusi@ti.com> Message-ID: <3759862.8IETAs1y1n@acer> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dnia pi?tek, 14 wrze?nia 2012 15:05:43 Peter Ujfalusi pisze: > Hello, > > Changes since v2: > - As it has been discussed the no_wakeup parameter has been replaced with flags > for the dmaengine APIs > > Changes since v1: > - Support for pause/resume for OMAP audio via dmaengine > - dmaengine: support for NO_PERIOD_WAKEUP in cyclic mode > - OMAP to keep supporting NO_PERIOD_WAKEUP for audio > - Other plaforms can also try to enable this mode since we have now generic > interface to do so. > > This series will switch the OMAP audio to use dmaengine. > The final patch which does the switch was based on Russell King's earlier patch. > > The first 10 patch is to prepare the OMAP audio drivers for a smooth change to > dmaengine: > - sDMA FRAME sync mode is removed and replaced with PACKET mode > - dai drivers no longer need to configure sDMA sync mode > - dai drivers does not need to specify the DMA word length - with the exception > of the omap-hdmi driver which requires 32bit word length regardless of the > audio format in use > - the McPDM driver used (to my surprise) hackish way of getting the DMA channel > and address - via defines from some header files > > After the conversion OMAP audio support should have the same features as before, > no regressions expected. > > I have tested the series on: > - BeagleBoard (audio via McBSP): > - aplay/arecord. In element mode and in threshold mode with different period > sizes > - mplayer -ao alsa: for direct ALSA access > - mplayer -ao pulse: via PulseAudio to test NO_PERIOD_WAKEUP feature > - OMAP4 Blaze (audio via McPDM and DMIC) > - aplay/arecord > - mplayer -ao alsa: for direct ALSA access > - mplayer -ao pulse: via PulseAudio to test NO_PERIOD_WAKEUP feature > > The patches has been generated against: > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7 > > Janusz: Can you retest this series on OMAP1 to be sure I have not broken it? Hi Peter, It looks like you haven't :-). For OMAP1: Tested-by: Janusz Krzysztofik Thanks, Janusz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215Ab2IOVlJ (ORCPT ); Sat, 15 Sep 2012 17:41:09 -0400 Received: from d1.icnet.pl ([212.160.220.21]:55220 "EHLO d1.icnet.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788Ab2IOVlH convert rfc822-to-8bit (ORCPT ); Sat, 15 Sep 2012 17:41:07 -0400 From: Janusz Krzysztofik To: alsa-devel@alsa-project.org Cc: Peter Ujfalusi , Mark Brown , Liam Girdwood , Tony Lindgren , Russell King , Vinod Koul , Dan Williams , Jarkko Nikula , Lars-Peter Clausen , Ricardo Neri , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH v3 00/15] ASoC: OMAP: Convert to use dmaengine Date: Sat, 15 Sep 2012 23:38:32 +0200 Message-ID: <3759862.8IETAs1y1n@acer> Organization: Tele-Info-System, Poznan, PL User-Agent: KMail/4.8.3 (Linux/3.3.8-gentoo; KDE/4.8.3; i686; ; ) In-Reply-To: <1347624358-25582-1-git-send-email-peter.ujfalusi@ti.com> References: <1347624358-25582-1-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-SA-Exim-Scanned: No (on d1.icnet); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dnia piątek, 14 września 2012 15:05:43 Peter Ujfalusi pisze: > Hello, > > Changes since v2: > - As it has been discussed the no_wakeup parameter has been replaced with flags > for the dmaengine APIs > > Changes since v1: > - Support for pause/resume for OMAP audio via dmaengine > - dmaengine: support for NO_PERIOD_WAKEUP in cyclic mode > - OMAP to keep supporting NO_PERIOD_WAKEUP for audio > - Other plaforms can also try to enable this mode since we have now generic > interface to do so. > > This series will switch the OMAP audio to use dmaengine. > The final patch which does the switch was based on Russell King's earlier patch. > > The first 10 patch is to prepare the OMAP audio drivers for a smooth change to > dmaengine: > - sDMA FRAME sync mode is removed and replaced with PACKET mode > - dai drivers no longer need to configure sDMA sync mode > - dai drivers does not need to specify the DMA word length - with the exception > of the omap-hdmi driver which requires 32bit word length regardless of the > audio format in use > - the McPDM driver used (to my surprise) hackish way of getting the DMA channel > and address - via defines from some header files > > After the conversion OMAP audio support should have the same features as before, > no regressions expected. > > I have tested the series on: > - BeagleBoard (audio via McBSP): > - aplay/arecord. In element mode and in threshold mode with different period > sizes > - mplayer -ao alsa: for direct ALSA access > - mplayer -ao pulse: via PulseAudio to test NO_PERIOD_WAKEUP feature > - OMAP4 Blaze (audio via McPDM and DMIC) > - aplay/arecord > - mplayer -ao alsa: for direct ALSA access > - mplayer -ao pulse: via PulseAudio to test NO_PERIOD_WAKEUP feature > > The patches has been generated against: > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7 > > Janusz: Can you retest this series on OMAP1 to be sure I have not broken it? Hi Peter, It looks like you haven't :-). For OMAP1: Tested-by: Janusz Krzysztofik Thanks, Janusz