From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94EFC04E69 for ; Mon, 31 Jul 2023 07:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231474AbjGaHcB (ORCPT ); Mon, 31 Jul 2023 03:32:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbjGaHbf (ORCPT ); Mon, 31 Jul 2023 03:31:35 -0400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D474EDC; Mon, 31 Jul 2023 00:30:37 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VoaPEop_1690788632; Received: from 30.240.113.95(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VoaPEop_1690788632) by smtp.aliyun-inc.com; Mon, 31 Jul 2023 15:30:34 +0800 Message-ID: <375a0706-b76e-e8a8-cdac-ed628af6643c@linux.alibaba.com> Date: Mon, 31 Jul 2023 15:30:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v6 0/4] drivers/perf: add Synopsys DesignWare PCIe PMU driver support Content-Language: en-US To: Will Deacon Cc: Bjorn Helgaas , Jonathan Cameron , chengyou@linux.alibaba.com, kaishen@linux.alibaba.com, yangyicong@huawei.com, baolin.wang@linux.alibaba.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, rdunlap@infradead.org, mark.rutland@arm.com, zhuo.song@linux.alibaba.com References: <20230725205955.GA665326@bhelgaas> <634f4762-cf2e-4535-f369-4032d65093f0@linux.alibaba.com> <20230728133926.GC21394@willie-the-truck> From: Shuai Xue In-Reply-To: <20230728133926.GC21394@willie-the-truck> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2023/7/28 21:39, Will Deacon wrote: > On Thu, Jul 27, 2023 at 11:45:22AM +0800, Shuai Xue wrote: >> >> >> On 2023/7/26 04:59, Bjorn Helgaas wrote: >>> On Mon, Jul 24, 2023 at 10:18:07AM +0100, Jonathan Cameron wrote: >>>> On Mon, 24 Jul 2023 10:34:08 +0800 >>>> Shuai Xue wrote: >>>>> On 2023/7/10 20:04, Shuai Xue wrote: >>>>>> On 2023/6/16 16:39, Shuai Xue wrote: >>>>>>> On 2023/6/6 15:49, Shuai Xue wrote: >>> >>>>>>>> This patchset adds the PCIe Performance Monitoring Unit (PMU) driver support >>>>>>>> for T-Head Yitian 710 SoC chip. Yitian 710 is based on the Synopsys PCI Express >>>>>>>> Core controller IP which provides statistics feature. >>> >>>> ... >>>> Really a question for Bjorn I think, but here is my 2 cents... >>>> >>>> The problem here is that we need to do that fundamental redesign of the >>>> way the PCI ports drivers work. I'm not sure there is a path to merging >>>> this until that is done. The bigger problem is that I'm not sure anyone >>>> is actively looking at that yet. I'd like to look at this (as I have >>>> the same problem for some other drivers), but it is behind various >>>> other things on my todo list. >>>> >>>> Bjorn might be persuaded on a temporary solution, but that would come >>>> with some maintenance problems, particularly when we try to do it >>>> 'right' in the future. Maybe adding another service driver would be >>>> a stop gap as long as we know we won't keep doing so for ever. Not sure. >>> >>> I think the question here is around the for_each_pci_dev() in >>> __dwc_pcie_pmu_probe()? I don't *like* that because of the >>> assumptions it breaks (autoload doesn't work, hotplug doesn't work), >>> but: >>> >>> - There are several other drivers that also do this, >>> - I don't have a better suggest for any of them, >>> - It's not a drivers/pci thing, so not really up to me anyway, >>> >>> so I don't have any problem with this being merged as-is, as long as >>> you can live with the limitations. >>> >>> I don't think this series does anything to work around those >>> limitations, i.e., it doesn't make up fake device IDs for module >>> loading or fake events for hotplug, so it seems like we could improve >>> the implementation later if we ever have a way to do it. >>> >>> Bjorn >> >> + Will >> >> Ok, thank you for confirmation, Bjorn. Then it comes to perf driver parts and >> it is really a question for @Will I think. >> >> What's your opinion about merging this patch set, @Will? > > No fundamental objection from me, but I'll have a closer look when you > post a version addressing the feedback from Jonathan and Yicong. Thanks for your input! I appreciate that you don't have any fundamental objections to merging the patch set. I'll definitely take into account the feedback from Jonathan and Yicong before posting a revised version. Best Regards, Cheers. Shuai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38C34C001DF for ; Mon, 31 Jul 2023 07:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zZgoCSx8cEZq4pnsl3NaO5KR/R+DnMV3/Kma+PGimZY=; b=A9wCaceSheoNmj hsghabb1tZ+QEvsIpW4LcbYl7s+JFv3nM62Y65+xFT9Y7oAZMLhEuJGS1h0fllivkts7s6nUXJuY0 xRSxO3Eb32c6oOdg2OPQe9MH4hNN/IrWo8nezkakrFV1wgMSBIHOxL8RoQWvGvqGCitJcVlu7SkcK RuwrpDYnL9s/keQ+zsgDGHR0h8uaBwiUvbU8bAT64d8raKGqupSURef65+c+YdpQ8QMq/tCuzARML yAsaAC5ifagk2XuDEIt+p6bOh95l9jNW28ai9ntay0JkVhZLTeA1KmAjDyhWvyBj6rboQhuS60Iwb iPl7EI79TfMb85BNJqFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQNMb-00EJn2-2D; Mon, 31 Jul 2023 07:30:45 +0000 Received: from out30-97.freemail.mail.aliyun.com ([115.124.30.97]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQNMY-00EJlg-2B for linux-arm-kernel@lists.infradead.org; Mon, 31 Jul 2023 07:30:44 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VoaPEop_1690788632; Received: from 30.240.113.95(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VoaPEop_1690788632) by smtp.aliyun-inc.com; Mon, 31 Jul 2023 15:30:34 +0800 Message-ID: <375a0706-b76e-e8a8-cdac-ed628af6643c@linux.alibaba.com> Date: Mon, 31 Jul 2023 15:30:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v6 0/4] drivers/perf: add Synopsys DesignWare PCIe PMU driver support Content-Language: en-US To: Will Deacon Cc: Bjorn Helgaas , Jonathan Cameron , chengyou@linux.alibaba.com, kaishen@linux.alibaba.com, yangyicong@huawei.com, baolin.wang@linux.alibaba.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, rdunlap@infradead.org, mark.rutland@arm.com, zhuo.song@linux.alibaba.com References: <20230725205955.GA665326@bhelgaas> <634f4762-cf2e-4535-f369-4032d65093f0@linux.alibaba.com> <20230728133926.GC21394@willie-the-truck> From: Shuai Xue In-Reply-To: <20230728133926.GC21394@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230731_003043_088358_EED5CF9E X-CRM114-Status: GOOD ( 22.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023/7/28 21:39, Will Deacon wrote: > On Thu, Jul 27, 2023 at 11:45:22AM +0800, Shuai Xue wrote: >> >> >> On 2023/7/26 04:59, Bjorn Helgaas wrote: >>> On Mon, Jul 24, 2023 at 10:18:07AM +0100, Jonathan Cameron wrote: >>>> On Mon, 24 Jul 2023 10:34:08 +0800 >>>> Shuai Xue wrote: >>>>> On 2023/7/10 20:04, Shuai Xue wrote: >>>>>> On 2023/6/16 16:39, Shuai Xue wrote: >>>>>>> On 2023/6/6 15:49, Shuai Xue wrote: >>> >>>>>>>> This patchset adds the PCIe Performance Monitoring Unit (PMU) driver support >>>>>>>> for T-Head Yitian 710 SoC chip. Yitian 710 is based on the Synopsys PCI Express >>>>>>>> Core controller IP which provides statistics feature. >>> >>>> ... >>>> Really a question for Bjorn I think, but here is my 2 cents... >>>> >>>> The problem here is that we need to do that fundamental redesign of the >>>> way the PCI ports drivers work. I'm not sure there is a path to merging >>>> this until that is done. The bigger problem is that I'm not sure anyone >>>> is actively looking at that yet. I'd like to look at this (as I have >>>> the same problem for some other drivers), but it is behind various >>>> other things on my todo list. >>>> >>>> Bjorn might be persuaded on a temporary solution, but that would come >>>> with some maintenance problems, particularly when we try to do it >>>> 'right' in the future. Maybe adding another service driver would be >>>> a stop gap as long as we know we won't keep doing so for ever. Not sure. >>> >>> I think the question here is around the for_each_pci_dev() in >>> __dwc_pcie_pmu_probe()? I don't *like* that because of the >>> assumptions it breaks (autoload doesn't work, hotplug doesn't work), >>> but: >>> >>> - There are several other drivers that also do this, >>> - I don't have a better suggest for any of them, >>> - It's not a drivers/pci thing, so not really up to me anyway, >>> >>> so I don't have any problem with this being merged as-is, as long as >>> you can live with the limitations. >>> >>> I don't think this series does anything to work around those >>> limitations, i.e., it doesn't make up fake device IDs for module >>> loading or fake events for hotplug, so it seems like we could improve >>> the implementation later if we ever have a way to do it. >>> >>> Bjorn >> >> + Will >> >> Ok, thank you for confirmation, Bjorn. Then it comes to perf driver parts and >> it is really a question for @Will I think. >> >> What's your opinion about merging this patch set, @Will? > > No fundamental objection from me, but I'll have a closer look when you > post a version addressing the feedback from Jonathan and Yicong. Thanks for your input! I appreciate that you don't have any fundamental objections to merging the patch set. I'll definitely take into account the feedback from Jonathan and Yicong before posting a revised version. Best Regards, Cheers. Shuai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel