From: Edward Cree <ecree.xilinx@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Ahmed Zaki <ahmed.zaki@intel.com>,
stephen@networkplumber.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, corbet@lwn.net,
jhs@mojatatu.com, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, "Chittim,
Madhu" <madhu.chittim@intel.com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
amritha.nambiar@intel.com,
Jan Sokolowski <jan.sokolowski@intel.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [RFC]: raw packet filtering via tc-flower
Date: Fri, 23 Feb 2024 12:36:16 +0000 [thread overview]
Message-ID: <375ff6ca-4155-bfd9-24f2-bd6a2171f6bf@gmail.com> (raw)
In-Reply-To: <ZdiOHpbYB3Ebwub5@nanopsycho>
On 23/02/2024 12:22, Jiri Pirko wrote:
> Nope, the extension of dissector would be clean, one timer. Just add
> support for offset+len based dissection.
... until someone else comes along with another kind of filtering and
wants _that_ in flower for the same reasons.
>> How about a new classifier that just does this raw matching?
>
> That's u32 basically, isn't it?
Well, u32 has all the extra complications around hashtables, links,
permoff... I guess you could have helpers in the kernel to stitch
'const' u32 filters into raw matches for drivers that only offload
that and reject anything else; and tc userspace could have syntactic
sugar to transform Ahmed's offset/pattern/mask into the appropriate
u32 matches under the hood.
next prev parent reply other threads:[~2024-02-23 12:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 19:43 [RFC]: raw packet filtering via tc-flower Ahmed Zaki
2024-02-23 2:40 ` Jakub Kicinski
2024-02-23 9:51 ` Jiri Pirko
2024-02-23 12:07 ` Edward Cree
2024-02-23 12:22 ` Jiri Pirko
2024-02-23 12:36 ` Edward Cree [this message]
2024-02-23 13:32 ` Jamal Hadi Salim
2024-02-23 13:44 ` Edward Cree
2024-02-26 14:40 ` Ahmed Zaki
2024-02-26 15:03 ` Jakub Kicinski
2024-02-27 15:25 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=375ff6ca-4155-bfd9-24f2-bd6a2171f6bf@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=ahmed.zaki@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jan.sokolowski@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.