From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 2 Aug 2002 09:51:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 2 Aug 2002 09:51:47 -0400 Received: from mail.ocs.com.au ([203.34.97.2]:36368 "HELO mail.ocs.com.au") by vger.kernel.org with SMTP id ; Fri, 2 Aug 2002 09:51:30 -0400 X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 From: Keith Owens To: Dave Jones , Linux-kernel Subject: Re: [PATCH] __devexit_p macro In-reply-to: Your message of "Fri, 02 Aug 2002 23:46:39 +1000." <3483.1028295999@ocs3.intra.ocs.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 02 Aug 2002 23:54:50 +1000 Message-ID: <3766.1028296490@ocs3.intra.ocs.com.au> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 02 Aug 2002 23:46:39 +1000, Keith Owens wrote: >On Fri, 2 Aug 2002 14:33:49 +0200, >Dave Jones wrote: >>On Fri, Aug 02, 2002 at 09:24:56AM +0000, Felipe W Damasio wrote: >> > +#ifdef MODULE || CONFIG_HOTPLUG >> > +#define __devexit_p(x) &(x) >> > +#else >> > #define __devexit_p(x) 0 >> > #endif >> >>Instead of making this a maze of #if/else's, you can acheive >>the same effect with the following patch that has been in my >>tree for a few months.. (hand pasted, may not apply cleanly) > >Better still, copy the end of 2.5.19-rc5/include/linux/init.h to Duh, that should be 2.4.19-rc5 of course. >2.5.30, from #ifdef CONFIG_HOTPLUG onwards. There is no point in >having slight differences between the 2.4 and 2.5 versions, ATM they >should be the same.