From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: kieran.bingham@ideasonboard.com,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/3] drm: rcar-du: Reject planes located fully off-screen
Date: Thu, 28 Sep 2017 12:16:48 +0300 [thread overview]
Message-ID: <37669611.vtIjLgZvls@avalon> (raw)
In-Reply-To: <20170928071034.ovxweoxdp3sb3ij2@phenom.ffwll.local>
Hi Daniel,
On Thursday, 28 September 2017 10:10:34 EEST Daniel Vetter wrote:
> On Wed, Sep 27, 2017 at 07:58:42PM +0100, Kieran Bingham wrote:
> > Hi Laurent,
> >
> > Thankyou for the patch,
> >
> > This looks good, and passes the tests.
> >
> > On 16/08/17 00:03, Laurent Pinchart wrote:
> > > There is no point in accepting fully off-screen planes as they won't be
> > > displayed. Reject them in the atomic check.
> > >
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> >
> > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Just a note, this is different from what i915 does. Not sure you want to
> intentionally be incompatible with i915 and hence defacto make this part
> of atomic undefined (or break some apps, depending upon how this pans
> out). I think X loves to put the cursor offscreen at least.
>
> I think we even have igts to test this properly.
If you update the documentation I'll submit a v2 that allows fully off-screen
planes :-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-09-28 9:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 23:03 [PATCH 0/3] R-Car DU: Clip planes to screen boundaries Laurent Pinchart
2017-08-15 23:03 ` [PATCH 1/3] drm: rcar-du: Share plane atomic check code between Gen2 and Gen3 Laurent Pinchart
2017-09-25 17:32 ` Kieran Bingham
2017-09-25 17:37 ` Kieran Bingham
2017-09-25 17:39 ` Kieran Bingham
2017-08-15 23:03 ` [PATCH 2/3] drm: rcar-du: Reject planes located fully off-screen Laurent Pinchart
2017-09-27 18:58 ` Kieran Bingham
2017-09-28 7:10 ` Daniel Vetter
2017-09-28 7:10 ` Daniel Vetter
2017-09-28 9:16 ` Laurent Pinchart [this message]
2017-09-28 9:27 ` Daniel Vetter
2017-09-28 9:27 ` Daniel Vetter
2017-08-15 23:03 ` [PATCH 3/3] drm: rcar-du: Clip planes to screen boundaries Laurent Pinchart
2017-08-15 23:03 ` Laurent Pinchart
2017-09-27 18:58 ` Kieran Bingham
2017-09-27 18:58 ` Kieran Bingham
2017-09-25 17:27 ` [PATCH 0/3] R-Car DU: " Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37669611.vtIjLgZvls@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.