From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/mlx5: revert multicast rule Verbs flow
	type
Date: Tue, 13 Feb 2018 17:03:31 +0100
Message-ID: <3777397.EmTq4m18zT@xps>
References: <20180213123155.44183-1-shahafs@mellanox.com>
 <20180213124104.x4qjimmomzmivxmb@laranjeiro-vm.dev.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org,
 =?ISO-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>,
 adrien.mazarguil@6wind.com, yskoh@mellanox.com, rasland@mellanox.com,
 stable@dpdk.org
To: Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180213124104.x4qjimmomzmivxmb@laranjeiro-vm.dev.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/02/2018 13:41, N=E9lio Laranjeiro:
> On Tue, Feb 13, 2018 at 02:31:55PM +0200, Shahaf Shuler wrote:
> > This is to revert the following commits:
> > commit da646bd93888 ("net/mlx5: fix all multi verification code positio=
n")
> > commit 0a40a1363a4d ("net/mlx5: fix flow type for allmulti rules")
> >=20
> > The last one introduced a bug in the following diff:
> > @ -1262,6 +1274,7 @@ struct ibv_spec_header {
> >                 eth.val.ether_type &=3D eth.mask.ether_type;
> >         }
> >         mlx5_flow_create_copy(parser, &eth, eth_size);
> > +       parser->allmulti =3D eth.val.dst_mac[0] & 1;
> >         return 0;
> >  }
> >=20
> > As broadcast rules will be considered of type allmulti as well.
> >=20
> > The patch was originally intended to enable VF to receive all multicast
> > traffic by using the IBV_FLOW_ATTR_MC_DEFAULT flow type.
> > Since the support was removed from the kernel there is no point with
> > fixing this issue, hence the revert.
> >=20
> > Cc: nelio.laranjeiro@6wind.com
> > Cc: rasland@mellanox.com
> > Cc: stable@dpdk.org
> >=20
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>=20
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied, thanks