Re: [PATCH 20/12] CI: Swap from perl to perl-base in build containers

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 15/07/2024 1:46 pm, Anthony PERARD wrote:
> On Sat, Jul 13, 2024 at 07:09:52PM +0100, Andrew Cooper wrote:
>> We only need a basic perl environment, not the things that a primarily-perl
>> project would want.
>>
>> Discovered during the Fedora refresh where the difference is ~40M, but it's
>> more modest for OpenSUSE and Ubuntu.
> "perl-base" on Ubuntu is quite different from "perl-base" on OpenSUSE
> Leap. I haven't check Tumbleweed but is probably the same as Leap.

/sigh - because that would have been too easy.

> So, I think these would deserve to be in separated patches.
>
> On Ubuntu, installing "perl" or "perl-base" or none of them makes no
> difference. We install "build-essentials" which pulls "dpkg-dev" which
> pulls "perl", so we don't test properly if "perl-base" is enough or if
> we need more.

Fine - lets leave the Ubuntu's alone.

>
> I tried to find out which Perl module we would need, and I've got this
> list:
>
> - get_maintainer
>     Getopt::Long;
> - add_maintainer
>     Getopt::Long;
>     File::Basename;
>     List::MoreUtils;
>     IO::Handle;
> - stubdom/vtpmmgr:
>     Digest::SHA qw(sha1);
>     Math::BigInt only => 'GMP';
> - kconfig
>     Getopt::Long;
> - ocaml/lib/xc/abi-check
>     Data::Dumper;
> - docs/gen-html-index
>     Getopt::Long;
>     IO::File;
>     File::Basename;
> - docs/xen-headers
>     Getopt::Long;
>     File::Find;
>     IO::File;
> (there's also tools/examples/xeninfo.pl, I dont't if that can still work
> or if we need to purge it)

Ewww.

my %xenhosts = ("192.0.2.10" => {"port" => "9363"}, ...

is enough to demonstrate it's a special purpose script.

That file isn't referenced by the Makefile, nor is anything in the vnc/
dir, so we should purge the lot.

>
> Then I've got whatever module is in "perl-base" pkg.
>
> For Leap's perl-base:
>     getopt:long
>     file:basename
>     io:handle
>     io:file
>     file:find
>     data:dumper
>     digest:sha
> So, add_maintainer.pl and the script in stubdom/vtpmmgr won't work. So
> that's probably fine for Leap.

vtpmmgr isn't built by default, so gets 0 testing in CI.  I don't expect
people to be using add_maintainer inside the containers either.

>
> For Ubuntu 22.04 (not check others, but likely about the same)
> there's more packages:
>     perl-base
>         getopt::long
>         file:basename
>         io:handle
>         io:file
>     perl-modules-5.34
>         file:find
>         math:bigint
>     libperl5.34
>         data:dumper
>         digest:sha
>     liblist-moreutils-perl
>         list:MoreUtils
>     librpc-xml-perl
>         rpc:xml
> ("perl" pkg pulls "perl-modules-5.34" and "libperl5.34")
>
> So with just "perl-base", the ocaml's abi-check wouldn't work, as well
> as the docs's script (probably ok for "docs" if we don't use containers
> to build them).

Hmm yeah - we wouldn't want to break that.

>  Also add_maintainer and stubdom/vtpmmgr like for Leap.
>
>
> So I would suggest to not touch the Ubuntu containers, make the change
> to the OpenSUSE one and maybe add the limitation to the commit message.

Ok - I'll do this.

~Andrew