From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivien Didelot Date: Thu, 30 Aug 2012 21:22:02 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: add Maxim MAX197 support Message-Id: <378258773.403150.1346361722651.JavaMail.root@mail.savoirfairelinux.com> List-Id: In-Reply-To: <20120830211444.GA11181@roeck-us.net> References: <1346351995-9038-1-git-send-email-vivien.didelot@savoirfairelinux.com> In-Reply-To: <1346351995-9038-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: lm-sensors@lm-sensors.org, Jean Delvare , linux-kernel@vger.kernel.org SSBndWVzcyB3ZSdyZSB0b28gZmFzdCEKCkkndmUganVzdCBzZWVuIHlvdXIgcmVwbHksIHRoaXMg aXMgbXVjaCBjbGVhbmVyLCBpbmRlZWQuCkknbGwgdXBkYXRlIHRoZSBtYXgxOTcgZHJpdmVyLCBh bmQgZml4IHRoZSBzaHQxNSBkcml2ZXIgYXMgc29vbiBhcyBJIGNhbi4KClRoYW5rcywKVml2aWVu CgotLS0tLSBNYWlsIG9yaWdpbmFsIC0tLS0tCkRlOiAiR3VlbnRlciBSb2VjayIgPGxpbnV4QHJv ZWNrLXVzLm5ldD4Kw4A6ICJWaXZpZW4gRGlkZWxvdCIgPHZpdmllbi5kaWRlbG90QHNhdm9pcmZh aXJlbGludXguY29tPgpDYzogbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZywgIkplYW4gRGVsdmFy ZSIgPGtoYWxpQGxpbnV4LWZyLm9yZz4sIGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKRW52 b3nDqTogSmV1ZGkgMzAgQW/Du3QgMjAxMiAxNzoxNDo0NApPYmpldDogUmU6IFtQQVRDSF0gaHdt b246IGFkZCBNYXhpbSBNQVgxOTcgc3VwcG9ydAoKT24gVGh1LCBBdWcgMzAsIDIwMTIgYXQgMDU6 MTA6MzJQTSAtMDQwMCwgVml2aWVuIERpZGVsb3Qgd3JvdGU6Cj4gSGkgR3VlbnRlciwKPiAKPiBU aGFua3MgZm9yIHlvdXIgZGV0YWlsZWQgY29tbWVudHMuIEknbGwgc2VuZCBhIG5ldyB2ZXJzaW9u IHNvb24uCj4gCj4gQWJvdXQgdGhlIGZvbGxvd2luZyBjb21tZW50LCBJIGFncmVlIHdpdGggeW91 LiBIb3dldmVyIGFzIHRoZXJlIGlzIG5vIGNvbnZlbnRpb24gZm9yIHRoaXMgY2FzZSwgZm9yIG5v dyBJIHdvdWxkIHByZWZlciB0byBzdGljayB3aXRoIHRoZSBtb2RlbCBhcyBzZWVuIGluIGRyaXZl cnMgc3VjaCBhcyBzaHQxNS4KPiAKQWN0dWFsbHksIHRoZXJlIGlzIGEgY29udmVudGlvbiwgYW5k IGl0IGlzIG11Y2ggY2xlYW5lciB0aGFuIHVzaW5nCm11bHRpcGxlIHBsYXRmb3JtIGRyaXZlciBp bnN0YW5jZXMuIEkgc2VudCB5b3UgYSBzZXBhcmF0ZSBlLW1haWwgYQptaW51dGUgYWdvLCBkZXNj cmliaW5nIGhvdyBpdCB3b3Jrcy4KCldlIHNob3VsZCBhY3R1YWxseSBmaXggdGhlIHNodDE1IGRy aXZlciBhcyB3ZWxsIHRvIHVzZSB0aGUgc2FtZSBhcHByb2FjaC4KClRoYW5rcywKR3VlbnRlcgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29y cyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0t c2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678Ab2H3VWG (ORCPT ); Thu, 30 Aug 2012 17:22:06 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:38091 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416Ab2H3VWE convert rfc822-to-8bit (ORCPT ); Thu, 30 Aug 2012 17:22:04 -0400 Date: Thu, 30 Aug 2012 17:22:02 -0400 (EDT) From: Vivien Didelot To: Guenter Roeck Cc: lm-sensors@lm-sensors.org, Jean Delvare , linux-kernel@vger.kernel.org Message-ID: <378258773.403150.1346361722651.JavaMail.root@mail.savoirfairelinux.com> In-Reply-To: <20120830211444.GA11181@roeck-us.net> Subject: Re: [PATCH] hwmon: add Maxim MAX197 support MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [208.88.110.46] X-Mailer: Zimbra 7.1.4_GA_2555 (ZimbraWebClient - FF3.0 (Linux)/7.1.4_GA_2555) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I guess we're too fast! I've just seen your reply, this is much cleaner, indeed. I'll update the max197 driver, and fix the sht15 driver as soon as I can. Thanks, Vivien ----- Mail original ----- De: "Guenter Roeck" À: "Vivien Didelot" Cc: lm-sensors@lm-sensors.org, "Jean Delvare" , linux-kernel@vger.kernel.org Envoyé: Jeudi 30 Août 2012 17:14:44 Objet: Re: [PATCH] hwmon: add Maxim MAX197 support On Thu, Aug 30, 2012 at 05:10:32PM -0400, Vivien Didelot wrote: > Hi Guenter, > > Thanks for your detailed comments. I'll send a new version soon. > > About the following comment, I agree with you. However as there is no convention for this case, for now I would prefer to stick with the model as seen in drivers such as sht15. > Actually, there is a convention, and it is much cleaner than using multiple platform driver instances. I sent you a separate e-mail a minute ago, describing how it works. We should actually fix the sht15 driver as well to use the same approach. Thanks, Guenter