All of lore.kernel.org
 help / color / mirror / Atom feed
From: subhashj@codeaurora.org
To: Kyuho Choi <chlrbgh0@gmail.com>
Cc: vinholikatti@gmail.com, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, Kyuho Choi <kyuho.choi@sk.com>,
	linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: enable no vccq quirk for skhynix device
Date: Tue, 27 Sep 2016 13:09:34 -0700	[thread overview]
Message-ID: <378bfe51eb7d16a64dc629c195dd72dc@codeaurora.org> (raw)
In-Reply-To: <1474901905-21551-1-git-send-email-kyuho.choi@sk.com>

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

On 2016-09-26 07:58, Kyuho Choi wrote:
> This patch enable no vccq quirk for SKHynix devices.
> SKHynix ufs device don't need vccq vrail for device operation.
> 
> Signed-off-by: Kyuho Choi <kyuho.choi@sk.com>
> ---
>  drivers/scsi/ufs/ufs_quirks.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufs_quirks.h 
> b/drivers/scsi/ufs/ufs_quirks.h
> index ee4ab85..22f881e 100644
> --- a/drivers/scsi/ufs/ufs_quirks.h
> +++ b/drivers/scsi/ufs/ufs_quirks.h
> @@ -25,6 +25,7 @@
> 
>  #define UFS_VENDOR_TOSHIBA     0x198
>  #define UFS_VENDOR_SAMSUNG     0x1CE
> +#define UFS_VENDOR_SKHYNIX     0x1AD
> 
>  /**
>   * ufs_device_info - ufs device details
> @@ -145,6 +146,7 @@ static struct ufs_dev_fix ufs_fixups[] = {
>  		UFS_DEVICE_QUIRK_PA_TACTIVATE),
>  	UFS_FIX(UFS_VENDOR_TOSHIBA, "THGLF2G9D8KBADG",
>  		UFS_DEVICE_QUIRK_PA_TACTIVATE),
> +	UFS_FIX(UFS_VENDOR_SKHYNIX, UFS_ANY_MODEL, UFS_DEVICE_NO_VCCQ),
> 
>  	END_FIX
>  };

  reply	other threads:[~2016-09-27 20:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 14:58 [PATCH] scsi: ufs: enable no vccq quirk for skhynix device Kyuho Choi
2016-09-27 20:09 ` subhashj [this message]
2016-09-28  5:09 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=378bfe51eb7d16a64dc629c195dd72dc@codeaurora.org \
    --to=subhashj@codeaurora.org \
    --cc=chlrbgh0@gmail.com \
    --cc=kyuho.choi@sk.com \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.