From: Arnd Bergmann <arnd@arndb.de>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: turn NF_HOOK into an inline function
Date: Fri, 09 Oct 2015 15:15:59 +0200 [thread overview]
Message-ID: <37905061.HAWoCKur8L@wuerfel> (raw)
In-Reply-To: <201510092113.o4u2vjMD%fengguang.wu@intel.com>
On Friday 09 October 2015 21:03:57 kbuild test robot wrote:
> ^1da177e Linus Torvalds 2005-04-16 818 cb->rt_flags &= ~DN_RT_F_IE;
> ^1da177e Linus Torvalds 2005-04-16 819 if (rt->rt_flags & RTCF_DOREDIRECT)
> ^1da177e Linus Torvalds 2005-04-16 820 cb->rt_flags |= DN_RT_F_IE;
> ^1da177e Linus Torvalds 2005-04-16 821
> 29a26a56 Eric W. Biederman 2015-09-15 822 return NF_HOOK(NFPROTO_DECNET, NF_DN_FORWARD,
> 29a26a56 Eric W. Biederman 2015-09-15 @823 &init_net, NULL, skb, dev, skb->dev,
> 8f40b161 David S. Miller 2011-07-17 824 dn_to_neigh_output);
> ^1da177e Linus Torvalds 2005-04-16 825
> ^1da177e Linus Torvalds 2005-04-16 826 drop:
>
Ah, right. The 'dev' variable here is declared as
#ifdef CONFIG_NETFILTER
struct net_device *dev = skb->dev;
#endif
Apparently because the code produced the same warning as the ipv6 code.
Removing the #ifdef here would make that code nicer and let us use
my patch. Alternatively we could put the same #ifdef into IPV6 and
not use the inline function.
Any opinions?
Arnd
next prev parent reply other threads:[~2015-10-09 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 12:45 [PATCH] netfilter: turn NF_HOOK into an inline function Arnd Bergmann
2015-10-09 13:03 ` kbuild test robot
2015-10-09 13:15 ` Arnd Bergmann [this message]
2015-10-09 18:21 ` Eric W. Biederman
2015-10-09 18:28 ` Eric W. Biederman
2015-10-09 18:45 ` [PATCH v2] " Arnd Bergmann
2015-10-16 16:45 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37905061.HAWoCKur8L@wuerfel \
--to=arnd@arndb.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.