From: Jan Janssen <medhefgo@web.de>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Daniele Venzano <venza@brownhat.org>, netdev@vger.kernel.org
Subject: Re: PROBLEM: freeze when resuming from suspend-to-ram
Date: Sun, 18 Nov 2012 11:28:16 +0100 [thread overview]
Message-ID: <3791100.UEdZkjCSEi@brinja> (raw)
In-Reply-To: <20121117192036.GA29018@electric-eye.fr.zoreil.com>
On Saturday 17 November 2012 20:20:36 Francois Romieu wrote:
> Jan Janssen <medhefgo@web.de> :
> [...]
>
> > I'd be glad to help you with that. The bug happens with 3.6.6 and with
> > 3.7-
> > rc6. Pick one that suits you best, I can work with both.
>
> /me slaps head.
>
> Please try the patch below against v3.7-rc6
>
> diff --git a/drivers/net/ethernet/sis/sis900.c
> b/drivers/net/ethernet/sis/sis900.c index fb9f6b3..edf5edb 100644
> --- a/drivers/net/ethernet/sis/sis900.c
> +++ b/drivers/net/ethernet/sis/sis900.c
> @@ -2479,7 +2479,7 @@ static int sis900_resume(struct pci_dev *pci_dev)
> netif_start_queue(net_dev);
>
> /* Workaround for EDB */
> - sis900_set_mode(ioaddr, HW_SPEED_10_MBPS, FDX_CAPABLE_HALF_SELECTED);
> + sis900_set_mode(sis_priv, HW_SPEED_10_MBPS, FDX_CAPABLE_HALF_SELECTED);
>
> /* Enable all known interrupts by setting the interrupt mask. */
> sw32(imr, RxSOVR | RxORN | RxERR | RxOK | TxURN | TxERR | TxIDLE);
This seems to fix it. I was able to repeatedly suspend and resume.
On my first resume try I did get a netdev watchdog timeout right after I got
back to my shell prompt, but it wasn't reproducable. So, I'm assuming it's
some unrelated rc or hardware issue. Thought I might better mention it.
Jan
prev parent reply other threads:[~2012-11-18 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 19:47 PROBLEM: freeze when resuming from suspend-to-ram medhefgo
2012-11-14 21:11 ` Daniele Venzano
2012-11-17 10:57 ` Francois Romieu
2012-11-17 13:21 ` Jan Janssen
2012-11-17 19:20 ` Francois Romieu
2012-11-18 10:28 ` Jan Janssen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3791100.UEdZkjCSEi@brinja \
--to=medhefgo@web.de \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=venza@brownhat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.