From: Martin Costabel <costabel@wanadoo.fr>
To: "Joshua M. Thompson" <funaho@jurai.org>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: 2.3.18 and CONFIG_ADB_MOUSE
Date: Mon, 13 Sep 1999 08:55:59 +0200 [thread overview]
Message-ID: <37DC9FFF.5C5A18F7@wanadoo.fr> (raw)
In-Reply-To: Pine.LNX.4.10.9909130140010.29981-100000@ifurita.jurai.org
"Joshua M. Thompson" wrote:
>
> On Sat, 11 Sep 1999, Martin Costabel wrote:
>
> > I had seen the typo in drivers/char/Config.in, but forgot to correct it.
> > And then it seemed more logical to have the selection of ADB_MOUSE next
> > to ADB_KEYBOARD, but maybe it isn't.
>
> It is more logical, and that's the way I have it listed on the 68K Mac
> port. What I believe should happen is that the ADB keyboard driver should
> be put in drivers/char where the mouse driver already resides. Then they
> can both be listed next to each other in the drivers/char/config.in file,
> bracked by a nice clean 'if [ "$CONFIG_ADB" = 'y' ];'
It's not so clear to me now. If one thinks of menus as in 'make
{x|menu}config', there is a submenu for mice, but nothing for keyboards,
probably because for PCs there is basically only one keyboard (?). When
USB support matures, this will have to change, I guess.
Another small nit to pick: The adbmouse driver is offered as a module,
but it doesn't compile when CONFIG_ADB_MOUSE=m is selected. The reason
is this new
__setup("adb_buttons=", adb_mouse_setup);
line which is a fallout from the implosion of init/main.c.
In <linux/init.h>, __setup is only defined #ifndef MODULE. I don't know
how other drivers handle this problem; in vger-2.3.18, the popular
"atyfb=" kernel argument seems to have disappeared completely, for
instance.
--
Martin
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~1999-09-13 6:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-09 5:18 Paul's devel branch on Lombard? Hugh Caley
1999-09-09 14:25 ` Shaw Terwilliger
1999-09-09 14:51 ` Hugh Caley
1999-09-09 21:03 ` Martin Costabel
1999-09-09 21:30 ` Shaw Terwilliger
1999-09-09 22:45 ` Martin Costabel
1999-09-10 0:07 ` David D. Kilzer
1999-09-10 0:29 ` Paul Mackerras
1999-09-10 9:42 ` Geert Uytterhoeven
1999-09-10 9:46 ` Geert Uytterhoeven
1999-09-10 17:49 ` Martin Costabel
1999-09-10 22:08 ` 2.3.18 and CONFIG_ADB_MOUSE Martin Costabel
1999-09-10 23:55 ` Joshua M. Thompson
1999-09-11 8:04 ` Martin Costabel
1999-09-13 5:43 ` Joshua M. Thompson
1999-09-13 6:55 ` Martin Costabel [this message]
1999-09-13 7:29 ` Geert Uytterhoeven
1999-09-13 8:32 ` Martin Costabel
1999-09-13 8:54 ` Geert Uytterhoeven
1999-09-11 3:37 ` Paul Mackerras
1999-09-11 3:47 ` David D. Kilzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37DC9FFF.5C5A18F7@wanadoo.fr \
--to=costabel@wanadoo.fr \
--cc=funaho@jurai.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.