From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A8122877E5 for ; Wed, 25 Feb 2026 14:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772030892; cv=none; b=crzrPRJv0V6wnkMukoKueY/4/tXsYEN3nIgG+/fMHk8lwIv5YHXrkdm8F1cwJOJiyCwAh1MbLOvxNLeLDjFS6JSRMqgg+/k1i9+wviFIJ+FVH4jf1k4vPsTBV2/QAUQ3wyuYDhjfcX4m1Y7SOJH0uCeCatjXvSQfiHy7tLgeiGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772030892; c=relaxed/simple; bh=YFDv7oCzlpd4BRkBEA57j9V63JC6HtZ/vT6jZ/TejPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=shl52cHQh6qv6ITr6hg/Tv6xjSh3A2dyZYljX8wJLlyZomp92qeU8HQlfcCFM8cc2aHWvMtPZHo5P3+OrGnQ0p3hk6VGRViRzFQMZ7xaZmnQCdIey+n17b66xtkamyCWG4mXFuoKw61H2ZqmmwEa3lRYp4rQhFCr8OGAWKuZu2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dFpmoKUR; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dFpmoKUR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772030891; x=1803566891; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=YFDv7oCzlpd4BRkBEA57j9V63JC6HtZ/vT6jZ/TejPY=; b=dFpmoKURPcr6ZAiIpRd6qOJ8BPStdFc8UP0wQQODURDT1pjzPxQTQMoY +7k1kEoOrEVXSX05ZRL9MN4xX2UhoZA7thNTnPBdtsk5Y/+OtrQOT8ri+ 4fmeDs9N3cGt1YY7QfMQGhLRXj3OYAlAigT+wz/huDs8wMGWKMQl/qatK G7w1PRRuev64ywYryzzFDuvumAf6Uh/ITanonUmQHIM4PVf7OdvO93EQL moIhj1XC9JDMDB/gKGd1lzUZLtOKP0Lwfv28WRIB7N3YIgZvaG/4FkDlw 3GfEAQrr+2zaB4CtmEjHFGDJE5uGW9kPZJrG8UwXn6EEzM6ZBzeVpDkQP w==; X-CSE-ConnectionGUID: T/1aiD6OQKaIAPHUlIfGLg== X-CSE-MsgGUID: ZCmtQlrDR2qwpo3tb0a6MQ== X-IronPort-AV: E=McAfee;i="6800,10657,11712"; a="73043328" X-IronPort-AV: E=Sophos;i="6.21,310,1763452800"; d="scan'208";a="73043328" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2026 06:48:10 -0800 X-CSE-ConnectionGUID: Cr7jdH2zTp63KfQtTcrVAg== X-CSE-MsgGUID: j/0ZE7m8SaSmF62R1Wj3UQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,310,1763452800"; d="scan'208";a="216135123" Received: from spandruv-mobl5.amr.corp.intel.com (HELO [10.125.111.56]) ([10.125.111.56]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2026 06:48:10 -0800 Message-ID: <37a4b02c-5860-4d02-893e-e624b758f042@intel.com> Date: Wed, 25 Feb 2026 06:48:09 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 05/13] x86/mm: Reset tag for virtual to physical address conversions To: Maciej Wieczor-Retman Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Maciej Wieczor-Retman , Alexander Potapenko , linux-kernel@vger.kernel.org References: <51598144b682a57f50ec8da65a52b005701f309e.1768845098.git.m.wieczorretman@pm.me> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/25/26 00:17, Maciej Wieczor-Retman wrote: > On 2026-02-23 at 12:33:01 -0800, Dave Hansen wrote: >>> #ifdef CONFIG_X86_64 >>> #include >>> @@ -65,6 +66,13 @@ static inline void copy_user_page(void *to, void *from, unsigned long vaddr, >>> * virt_to_page(kaddr) returns a valid pointer if and only if >>> * virt_addr_valid(kaddr) returns true. >>> */ >>> + >>> +#ifdef CONFIG_KASAN_SW_TAGS >>> +#define page_to_virt(x) ({ \ >>> + void *__addr = __va(page_to_pfn((struct page *)x) << PAGE_SHIFT); \ >>> + __tag_set(__addr, page_kasan_tag(x)); \ >>> +}) >>> +#endif >> >> Can we pretty please keep this in arch-independent code? >> >> The idea of tags is not x86-specific and I can almost guarantee that x86 >> won't be the last one needing this. > > Do you mean adding a KASAN oriented page_to_virt() that's arch independent? I'd > guess next to the regular one, in include/linux/mm.h? Close. There should be one and one only arch-independent page_to_virt() that uses __tag_set(). Then, since __tag_set() gets compiled out when KASAN is off, you get to keep a single page_to_virt() implementation that compiles down to the original implementation when KASAN is off. BTW, you can get __tag_set() down to a single implementation too: static inline void *__tag_set(const void *__addr, u8 tag) { u64 addr = (u64)__addr; if (IS_ENABLED(CONFIG_KASAN_SW_TAGS)) { addr &= ~__tag_shifted(KASAN_TAG_BITS_MASK); addr |= __tag_shifted(tag & KASAN_TAG_BITS_MASK); } return (void *)addr; } That shifts the actual #ifdeffery all the way back to the constants. At this level it doesn't really matter much though. Just do whatever is easy to read.