From: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] clk: qcom: gcc-glymur: use shared ops for GCC UFS RCGs
Date: Tue, 15 Sep 2026 17:20:14 +0530 [thread overview]
Message-ID: <37ce680d-42b1-420f-b42c-1ea4aca424db@oss.qualcomm.com> (raw)
In-Reply-To: <46c248d9-fc74-4f3c-85b7-8b678ae3c723@oss.qualcomm.com>
On 9/7/2026 1:32 PM, Konrad Dybcio wrote:
> On 9/4/26 8:50 PM, Jagadeesh Kona wrote:
>> Switch GCC UFS RCGs to shared ops so that they are safely parked at XO
>> during clk registration.
>>
>> This ensures the RCGs are connected to a valid running source clk before
>> the UFS GDSC is enabled, which is a requirement for the UFS GDSC power-on
>> sequence.
>>
>> Fixes: efe504300a17 ("clk: qcom: gcc: Add support for Global Clock Controller")
>> Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
>> ---
>
> Is the no_init_park variant an actual problem here? When reading back
> _CFG, is the parent preset to the UFS clock (which isn't running)?
>
Sorry, it is not the problem, these RCGs don't have UFS clock as parent.
I have retested and realized this patch is not really required. Will drop
it in next version.
Thanks,
Jagadeesh
prev parent reply other threads:[~2026-09-15 11:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 18:50 [PATCH 0/4] clk: qcom: glymur: Add rpmh LNBB clks support and update UFS clk ops Jagadeesh Kona
2026-09-04 18:50 ` [PATCH 1/4] dt-bindings: clock: qcom: Add TCSR_UFS_CLKREF_EN definition Jagadeesh Kona
2026-09-07 7:58 ` Konrad Dybcio
2026-09-09 7:30 ` Krzysztof Kozlowski
2026-09-11 15:11 ` Jagadeesh Kona
2026-09-04 18:50 ` [PATCH 2/4] clk: qcom: rpmhcc: Add LNBB clocks support for Glymur Jagadeesh Kona
2026-09-05 5:52 ` Abel Vesa
2026-09-15 9:53 ` Jagadeesh Kona
2026-09-04 18:50 ` [PATCH 3/4] clk: qcom: gcc-glymur: Use clk_regmap_phy_mux_ops for GCC UFS muxes Jagadeesh Kona
2026-09-05 5:49 ` Abel Vesa
2026-09-07 7:59 ` Konrad Dybcio
2026-09-04 18:50 ` [PATCH 4/4] clk: qcom: gcc-glymur: use shared ops for GCC UFS RCGs Jagadeesh Kona
2026-09-04 19:02 ` sashiko-bot
2026-09-05 5:45 ` Abel Vesa
2026-09-07 8:02 ` Konrad Dybcio
2026-09-15 11:50 ` Jagadeesh Kona [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ce680d-42b1-420f-b42c-1ea4aca424db@oss.qualcomm.com \
--to=jagadeesh.kona@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jbrunet+clk@baylibre.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.