From: Mark Harmstone <mark@harmstone.com>
To: Brahmajit Das <listout@listout.xyz>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
kees@kernel.org, ailiop@suse.com
Subject: Re: [PATCH v3] btrfs: replace deprecated strcpy with strscpy
Date: Fri, 20 Jun 2025 06:15:34 +0100 [thread overview]
Message-ID: <37cea83e-06b2-44c6-abe2-4bccc1cfd5c4@harmstone.com> (raw)
In-Reply-To: <20250620014344.27589-1-listout@listout.xyz>
On 20/06/2025 2.43 am, Brahmajit Das wrote:
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -215,7 +215,7 @@ void btrfs_describe_block_groups(u64 bg_flags, char *buf, u32 size_buf)
> u32 size_bp = size_buf;
>
> if (!flags) {
> - strcpy(bp, "NONE");
> + memcpy(bp, "NONE", 5);
> return;
> }
There's still the problem here that you're hardcoding a magic number,
and that memcpy is no safer than strcpy.
If your aim is to get rid of strcpy entirely in the codebase, this is
more than likely impossible.
next prev parent reply other threads:[~2025-06-20 5:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 14:06 [PATCH] btrfs: replace deprecated strcpy with strscpy Brahmajit Das
2025-06-19 15:39 ` [PATCH v2] " Brahmajit Das
2025-06-19 17:06 ` Mark Harmstone
2025-06-19 17:59 ` Brahmajit Das
2025-06-19 18:03 ` Mark Harmstone
2025-06-20 1:43 ` [PATCH v3] " Brahmajit Das
2025-06-20 5:15 ` Mark Harmstone [this message]
2025-06-20 12:27 ` David Sterba
2025-06-19 17:03 ` [PATCH] " Mark Harmstone
2025-06-19 18:02 ` Brahmajit Das
2025-06-20 12:24 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37cea83e-06b2-44c6-abe2-4bccc1cfd5c4@harmstone.com \
--to=mark@harmstone.com \
--cc=ailiop@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kees@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=listout@listout.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.