From: Guillaume Galeazzi <guillaume.galeazzi@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Guillaume G. via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] submodule--helper.c: add only-active to foreach
Date: Fri, 15 May 2020 13:04:56 +0200 [thread overview]
Message-ID: <37d9ea7b-8edc-e7e6-4f79-045d616de3e2@gmail.com> (raw)
In-Reply-To: <xmqqwo5fshe0.fsf@gitster.c.googlers.com>
Le 13.05.2020 à 22:35, Junio C Hamano a écrit :
> Guillaume Galeazzi <guillaume.galeazzi@gmail.com> writes:
>
> I already said I was *not* suggesting a concrete syntax. The more
> important point was to make us realize that we need to think outside
> of "active-only" and make sure we can support other kinds of selection
> criteria for submodules.
Ok get it now. So after looking a bit, another trait that could be
interesting filtering on is remote tracking branch. A v2 with filtering
based on active (or not), populated (or not), and tracked remote branch
is ready on my side. It also include the rename of the struct member
only_active to active_only. Let me know when I can /submit.
> So spelling out "--no-blah" to mean "not with blah" is probably a
> good thing to do (especially if readers do not mind being English
> centric).
>
Great, it make it a bit simpler to code, thanks for the tips.
next prev parent reply other threads:[~2020-05-15 11:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 8:26 [PATCH] submodule--helper.c: add only-active to foreach Guillaume G. via GitGitGadget
2020-05-10 16:44 ` Shourya Shukla
2020-05-10 21:51 ` Guillaume Galeazzi
2020-05-10 22:42 ` Eric Sunshine
2020-05-15 16:29 ` Guillaume Galeazzi
2020-05-12 14:15 ` Shourya Shukla
2020-05-15 16:51 ` Guillaume Galeazzi
2020-05-15 17:03 ` Junio C Hamano
2020-05-15 18:53 ` Guillaume Galeazzi
2020-05-12 18:53 ` Junio C Hamano
2020-05-13 5:17 ` Guillaume Galeazzi
2020-05-13 15:35 ` Junio C Hamano
2020-05-13 20:07 ` Guillaume Galeazzi
2020-05-13 20:35 ` Junio C Hamano
2020-05-15 11:04 ` Guillaume Galeazzi [this message]
2020-05-17 6:30 ` [PATCH v2 0/3] " Guillaume G. via GitGitGadget
2020-05-17 6:30 ` [PATCH v2 1/3] submodule--helper.c: add active " Guillaume Galeazzi via GitGitGadget
2020-05-17 6:30 ` [PATCH v2 2/3] submodule--helper.c: add populated " Guillaume Galeazzi via GitGitGadget
2020-05-17 6:30 ` [PATCH v2 3/3] submodule--helper.c: add branch " Guillaume Galeazzi via GitGitGadget
2020-05-17 15:46 ` [PATCH v2 0/3] submodule--helper.c: add only-active " Junio C Hamano
2020-05-17 19:47 ` Guillaume Galeazzi
2020-08-18 15:57 ` Guillaume Galeazzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37d9ea7b-8edc-e7e6-4f79-045d616de3e2@gmail.com \
--to=guillaume.galeazzi@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.