From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A81D4E7717F for ; Mon, 16 Dec 2024 07:18:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tN5MT-0006ja-1u; Mon, 16 Dec 2024 02:17:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tN5MQ-0006ib-2n for qemu-devel@nongnu.org; Mon, 16 Dec 2024 02:17:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tN5MO-0003K1-1I for qemu-devel@nongnu.org; Mon, 16 Dec 2024 02:17:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734333460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nY13gMQnOcGCxPaazUG5FZrd0pCRUYw+uY6lF4VKHh8=; b=TX2NHD7i1M73ktTNO5vooSV8kPh/30Yn3uAMDssnxuT3fLdkiuTQmjlB+Mv0Uo8d6UHmFI 1lPfRPhAjf/ZNLKijPHLirHFky0a6+pPN6nHoM8x5++vfTcK1LggM2ROXBF6TO1QDDU0Ls cDGgB/IbZgWdI17HS2XSqv/Q/Qkj0v0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-Om0h7bFPMK-C9CJ_BEwo1w-1; Mon, 16 Dec 2024 02:17:39 -0500 X-MC-Unique: Om0h7bFPMK-C9CJ_BEwo1w-1 X-Mimecast-MFC-AGG-ID: Om0h7bFPMK-C9CJ_BEwo1w Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3862f3ccf4fso1348974f8f.0 for ; Sun, 15 Dec 2024 23:17:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734333458; x=1734938258; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nY13gMQnOcGCxPaazUG5FZrd0pCRUYw+uY6lF4VKHh8=; b=L9n3BM3wAVEXAFk/EC1MmymPYr2cDIcfJTXXMbn+r4ZVHaLFmVCD9GigjFGXM0zkgI dp2HyUbm0cFHF0meRuwGv+W15/Fk1clm11snuy7CeBxGY7u/o5hm1GFTW4jtlbg2pA4e stRRHbCy3IyoepFIPwS+W4B8TXruUBSeEgrlMdtcqeeAM3sNpts/yDFJvcAVqHZPBBxs GC9C1xEtpxrSOk7rlqMNUm4a3H70Z8XJMEUI6MyvKGe7TEKwzVK8Kh8May6EstfFWirr UUSPAcLrcXPA0IWEqFnFR+eGJdsLKE4Bl843OQHGDLsL1PRrx6d2AmwEcXGZipa10Gin o4IQ== X-Forwarded-Encrypted: i=1; AJvYcCWebqBKBG2ndRHTazD/l17UIEFtV8Qwm8WjBPgCOp/f5ndWclUHenZIWafq3aRZ5RTKdUC5AqKSqEb7@nongnu.org X-Gm-Message-State: AOJu0YyN1cW8/D0/8XsPlDre22ZwDwEGAoP654xjOpasHsZQB9AnGpE5 WOLFfluIzGxMYyblV5WRo4ESkpSYY/yaPxy76MPc+wHSoR7OLbZpLC/26cn3J9mW7n3Ix8haSYE 363u1b4MXTQ2aFnVJ4bOzLLwrsrRjK80GwQ0LCTYQUAF5x2W7qwW+ X-Gm-Gg: ASbGncu85H+62FwG76Hs0EZHxNZb+aq1KEWlYgWmV36l2Zc2oNKalCIf1HunrHA2dQx AWOD9cfdlboaudn1RAk7u5TyitV8UAVDyqYe6UPJNNWGuERcgGphD7YJQY2Ivo82/ly7iBMIV34 SRb0bu4IW54c66jX/CcBzR7qlZvAFRVqVSRr/dI5cW9cgt7gZo3ZJBggiQg1TXCV5H5Ez9MDdBV s+N/o4fC8vz/+EgUDToOImzw+lGBAUnXz49cl0/nzBrVH6vldp9Adt+b7zPCjf6hD2O0W3eRnDU l8Cx5zhnAg== X-Received: by 2002:a5d:584c:0:b0:386:4a0d:bb21 with SMTP id ffacd0b85a97d-38880acda4cmr7947791f8f.22.1734333458176; Sun, 15 Dec 2024 23:17:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFT0yrgsHkK/wXdTFLh/u5yHuy/CjQYnbVAhlaIiq08HwfIDwYiHzA9rEX9pdSKH+hLzJWU4A== X-Received: by 2002:a5d:584c:0:b0:386:4a0d:bb21 with SMTP id ffacd0b85a97d-38880acda4cmr7947766f8f.22.1734333457866; Sun, 15 Dec 2024 23:17:37 -0800 (PST) Received: from [192.168.0.6] (ip-109-42-51-17.web.vodafone.de. [109.42.51.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c8016389sm7209446f8f.32.2024.12.15.23.17.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Dec 2024 23:17:37 -0800 (PST) Message-ID: <37dce27d-4668-44ee-87c6-afea090f3c91@redhat.com> Date: Mon, 16 Dec 2024 08:17:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] s390x: Fix CSS migration To: Fabiano Rosas , qemu-devel@nongnu.org Cc: Peter Xu , Paolo Bonzini , qemu-stable@nongnu.org, Richard Henderson , David Hildenbrand , Ilya Leoshkevich , Halil Pasic , Christian Borntraeger , Eric Farman References: <20241213160120.23880-1-farosas@suse.de> <20241213160120.23880-3-farosas@suse.de> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20241213160120.23880-3-farosas@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.168, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 13/12/2024 17.01, Fabiano Rosas wrote: > Commit a55ae46683 ("s390: move css_migration_enabled from machine to > css.c") disabled CSS migration globally instead of doing it > per-instance. > > CC: Paolo Bonzini > CC: qemu-stable@nongnu.org #9.1 > Fixes: a55ae46683 ("s390: move css_migration_enabled from machine to css.c") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2704 > Signed-off-by: Fabiano Rosas > --- > Consider enabling migration-compat-s390x in CI, it would have caught > this. It's too late for this development cycle because the backward > migration is broken, but in 10.1 both sides will agree on the > css_migration_enabled value. > --- > hw/s390x/s390-virtio-ccw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index fe03f716f3..701b2d4e2e 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -1189,6 +1189,7 @@ static void ccw_machine_2_9_instance_options(MachineState *machine) > s390_cpudef_featoff_greater(12, 1, S390_FEAT_ZPCI); > s390_cpudef_featoff_greater(12, 1, S390_FEAT_ADAPTER_INT_SUPPRESSION); > s390_cpudef_featoff_greater(12, 1, S390_FEAT_ADAPTER_EVENT_NOTIFICATION); > + css_migration_enabled = false; > } > > static void ccw_machine_2_9_class_options(MachineClass *mc) > @@ -1201,7 +1202,6 @@ static void ccw_machine_2_9_class_options(MachineClass *mc) > ccw_machine_2_10_class_options(mc); > compat_props_add(mc->compat_props, hw_compat_2_9, hw_compat_2_9_len); > compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); > - css_migration_enabled = false; > } > DEFINE_CCW_MACHINE(2, 9); > D'oh! Reviewed-by: Thomas Huth