All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Marxmeier <mike@msede.com>
To: Bruce Hewitson <hewitson@egs.uct.ac.za>
Cc: Heinz Mauelshagen <mge@ez-darmstadt.telekom.de>, linux-lvm@msede.com
Subject: Re: [linux-lvm] Can't see /dev/hdk1
Date: Sun, 10 Oct 1999 22:48:46 +0200	[thread overview]
Message-ID: <3800FBAE.A74F9163@msede.com> (raw)
In-Reply-To: Pine.WNT.4.05.9910081501230.-171375@socks.egs.uct.ac.za

Hi Bruce.

> There is no physical hdj* device, as I have kept the disks to one per IDE
> channel.  (By the way, if it helps, all drives work fine as stand alone
> ext2fs devices, and under md raid).

And that triggers a bug in pv_read_all_pv(). To opmize scan time for 
the cluttered /dev directory, pv_read_all_pv() tries to skip all
partitions for devices which don't exist.
Hover it's done in a wrong way ...

As a quick fix, have a look at lib/pv_read_all_pv.c and
modify it as below. The current code tries to skip partitions
if the device does not exist. However it blindly skips over the
next 15 devices it has found in /dev.

The code should look like:

         if ( ( tst = open ( dev_name, O_RDONLY)) == -1) {
            continue;
#if 0
            if ( MAJOR ( dir_cache[n].st_rdev) != MD_MAJOR &&
                 MINOR ( dir_cache[n].st_rdev) % 16 == 0) {
               n += 15;
               continue;
            }
#endif
         } else close ( tst);

Does this fix your problem?

The correct solution would be to order the dir_cache in major/minor
order and skip based on major/minor.


Hope this helps
Michael

-- 
Michael Marxmeier           Marxmeier Software AG
E-Mail: mike@msede.com      Besenbruchstrasse 9
Phone : +49 202 2431440     42285 Wuppertal, Germany
Fax   : +49 202 2431420     http://www.msede.com/

       reply	other threads:[~1999-10-10 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.WNT.4.05.9910081501230.-171375@socks.egs.uct.ac.za>
1999-10-10 20:48 ` Michael Marxmeier [this message]
1999-10-12 20:55 [linux-lvm] Can't see /dev/hdk1 Heinz Mauelshagen
  -- strict thread matches above, loose matches on Subject: below --
1999-10-08 10:06 Bruce Hewitson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3800FBAE.A74F9163@msede.com \
    --to=mike@msede.com \
    --cc=hewitson@egs.uct.ac.za \
    --cc=linux-lvm@msede.com \
    --cc=mge@ez-darmstadt.telekom.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.