From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v6 04/13] vhost: rxtx: prepare work for multiple queue support
Date: Tue, 20 Oct 2015 08:57:52 +0200 [thread overview]
Message-ID: <3814429.n33jvMuIcb@xps13> (raw)
In-Reply-To: <1444369572-1157-5-git-send-email-yuanhan.liu@linux.intel.com>
2015-10-09 13:46, Yuanhan Liu:
> From: Changchun Ouyang <changchun.ouyang@intel.com>
>
> Do not use VIRTIO_RXQ or VIRTIO_TXQ anymore; use the queue_id,
> instead, which will be set to a proper value for a specific queue
> when we have multiple queue support enabled.
>
> For now, queue_id is still set with VIRTIO_RXQ or VIRTIO_TXQ,
> so it should not break anything.
The title may be more informative.
Example:
vhost: use queue id instead of constant ring index
> - if (unlikely(queue_id != VIRTIO_RXQ)) {
> - LOG_DEBUG(VHOST_DATA, "mq isn't supported in this version.\n");
> + if (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->virt_qp_nb))) {
> + RTE_LOG(ERR, VHOST_DATA,
> + "%s (%"PRIu64"): virtqueue idx:%d invalid.\n",
> + __func__, dev->device_fh, queue_id);
[...]
> - if (unlikely(queue_id != VIRTIO_RXQ)) {
> - LOG_DEBUG(VHOST_DATA, "mq isn't supported in this version.\n");
> + if (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->virt_qp_nb))) {
> + RTE_LOG(ERR, VHOST_DATA,
> + "%s (%"PRIu64"): virtqueue idx:%d invalid.\n",
> + __func__, dev->device_fh, queue_id);
> + return 0;
[...]
> - if (unlikely(queue_id != VIRTIO_TXQ)) {
> - LOG_DEBUG(VHOST_DATA, "mq isn't supported in this version.\n");
> + if (unlikely(!is_valid_virt_queue_idx(queue_id, 1, dev->virt_qp_nb))) {
> + RTE_LOG(ERR, VHOST_DATA,
> + "%s (%"PRIu64"): virtqueue idx:%d invalid.\n",
> + __func__, dev->device_fh, queue_id);
Why not use the log macros in drivers/net/virtio/virtio_logs.h?
If you don't like the current log format, it would deserve a separate patch
to change them consistently.
next prev parent reply other threads:[~2015-10-20 6:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 5:45 [PATCH v6 00/13] vhost-user multiple queues enabling Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 01/13] vhost-user: add protocol features support Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 02/13] vhost-user: add VHOST_USER_GET_QUEUE_NUM message Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 03/13] vhost: vring queue setup for multiple queue support Yuanhan Liu
2015-10-20 6:49 ` Thomas Monjalon
2015-10-20 6:56 ` Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 04/13] vhost: rxtx: prepare work " Yuanhan Liu
2015-10-20 6:57 ` Thomas Monjalon [this message]
2015-10-20 7:10 ` Yuanhan Liu
2015-10-20 7:24 ` Thomas Monjalon
2015-10-09 5:46 ` [PATCH v6 05/13] vhost-user: handle VHOST_USER_RESET_OWNER correctly Yuanhan Liu
2015-10-20 7:03 ` Thomas Monjalon
2015-10-20 7:14 ` Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 06/13] virtio: read virtio_net_config correctly Yuanhan Liu
2015-10-20 7:07 ` Thomas Monjalon
2015-10-20 7:23 ` Yuanhan Liu
2015-10-20 7:27 ` Thomas Monjalon
2015-10-20 8:00 ` Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 07/13] vhost-user: enable vhost-user multiple queue Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 08/13] vhost: add VHOST_USER_SET_VRING_ENABLE message Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 09/13] vhost: add API bind a virtq to a specific core Yuanhan Liu
2015-10-20 6:16 ` Xie, Huawei
2015-10-20 6:25 ` Yuanhan Liu
2015-10-20 7:17 ` Thomas Monjalon
2015-10-09 5:46 ` [PATCH v6 10/13] ixgbe: support VMDq RSS in non-SRIOV environment Yuanhan Liu
2015-10-20 7:46 ` Thomas Monjalon
2015-10-21 10:05 ` Ananyev, Konstantin
2015-10-21 13:01 ` Yuanhan Liu
2015-10-21 13:03 ` Ananyev, Konstantin
2015-10-21 13:45 ` Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 11/13] examples/vhost: demonstrate the usage of vhost mq feature Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 12/13] examples/vhost: add per queue stats Yuanhan Liu
2015-10-09 5:46 ` [PATCH v6 13/13] doc: update release note for vhost-user mq support Yuanhan Liu
2015-10-09 13:45 ` [PATCH v6 00/13] vhost-user multiple queues enabling Marcel Apfelbaum
2015-10-19 13:16 ` Flavio Leitner
2015-10-20 10:39 ` Marcel Apfelbaum
2015-10-21 2:05 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3814429.n33jvMuIcb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.