From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2] drm: Remove some unused stuff from drm_plane Date: Wed, 19 Jun 2013 03:02:09 +0200 Message-ID: <3823036.ZJQZGNITBr@avalon> References: <1876492.8s97TbbtB8@avalon> <1368020454-5131-1-git-send-email-ville.syrjala@linux.intel.com> <3191357.hC906dTzJV@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <3191357.hC906dTzJV@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hello, On Wednesday 08 May 2013 15:52:10 Laurent Pinchart wrote: > On Wednesday 08 May 2013 16:40:54 ville.syrjala@linux.intel.com wrote: > > From: Ville Syrj=E4l=E4 > > = > > There's a bunch of unused members inside drm_plane, bloating the size of > > the structure needlessly. Eliminate them. > > = > > v2: Remove all of it from kernel-doc too > > = > > Signed-off-by: Ville Syrj=E4l=E4 > = > Reviewed-by: Laurent Pinchart Wow, I've managed to review the patch and miss that it broke compilation of = the shmob-drm driver :-( I'll send a patch to fix it. > > --- > > = > > drivers/gpu/drm/drm_crtc.c | 2 +- > > include/drm/drm_crtc.h | 11 ----------- > > 2 files changed, 1 insertion(+), 12 deletions(-) > > = > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > index d7c449f..e591914 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -1739,7 +1739,7 @@ int drm_mode_getplane(struct drm_device *dev, void > > *data, > > = > > plane_resp->plane_id =3D plane->base.id; > > plane_resp->possible_crtcs =3D plane->possible_crtcs; > > = > > - plane_resp->gamma_size =3D plane->gamma_size; > > + plane_resp->gamma_size =3D 0; > > = > > /* > > = > > * This ioctl is called twice, once to determine how much space is > > = > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > index adb3f9b..e11c6bc 100644 > > --- a/include/drm/drm_crtc.h > > +++ b/include/drm/drm_crtc.h > > @@ -654,11 +654,7 @@ struct drm_plane_funcs { > > * @format_count: number of formats supported > > * @crtc: currently bound CRTC > > * @fb: currently bound fb > > - * @gamma_size: size of gamma table > > - * @gamma_store: gamma correction table > > - * @enabled: enabled flag > > * @funcs: helper functions > > - * @helper_private: storage for drver layer > > * @properties: property tracking for this plane > > */ > > = > > struct drm_plane { > > @@ -674,14 +670,7 @@ struct drm_plane { > > struct drm_crtc *crtc; > > struct drm_framebuffer *fb; > > = > > - /* CRTC gamma size for reporting to userspace */ > > - uint32_t gamma_size; > > - uint16_t *gamma_store; > > - > > - bool enabled; > > - > > const struct drm_plane_funcs *funcs; > > - void *helper_private; > > = > > struct drm_object_properties properties; > > }; -- = Regards, Laurent Pinchart