From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] omapfb: dss: Do not duplicate features data
Date: Thu, 04 Jan 2018 14:10:56 +0000 [thread overview]
Message-ID: <3826269.phH0ahbWjF@amdc3058> (raw)
In-Reply-To: <20171129123308.GA26578@lenoch>
On Wednesday, November 29, 2017 06:03:14 PM Ladislav Michl wrote:
> On Wed, Nov 29, 2017 at 10:45:52AM -0600, Adam Ford wrote:
> [snip]
> > If it's correct and the patch is this one:
> > https://patchwork.kernel.org/patch/10082025/
>
> Yes.
>
> > Then you can mark me as:
> >
> > Tested-by: Adam Ford <aford173@gmail.com> #omap3630
>
> Thank you for testing. I'll wait a bit more for eventual objections
> and Marcus' decision about his credit before sending v2 :)
After adding Adam's Tested-by tag and fixing minor CodingStyle
errors reported by checkpatch.pl:
ERROR: "foo* bar" should be "foo *bar"
#37: FILE: drivers/video/fbdev/omap2/omapfb/dss/dispc.c:3979:
+static const struct dispc_features* dispc_get_features(void)
ERROR: "foo* bar" should be "foo *bar"
#114: FILE: drivers/video/fbdev/omap2/omapfb/dss/dss.c:890:
+static const struct dss_features* dss_get_features(void)
ERROR: "foo* bar" should be "foo *bar"
#199: FILE: drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c:192:
+static const struct hdmi_phy_features* hdmi_phy_get_features(void)
I've queued your patch for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2018-01-04 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 12:33 [PATCH] omapfb: dss: Do not duplicate features data Ladislav Michl
2017-11-29 15:12 ` Adam Ford
2017-11-29 16:08 ` Ladislav Michl
2017-11-29 16:36 ` Adam Ford
2017-11-29 16:45 ` Adam Ford
2017-11-29 17:03 ` Ladislav Michl
2018-01-04 14:10 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3826269.phH0ahbWjF@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.