From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 06/16] drm/i915: Replace ironlake_compute_wm0 with g4x_compute_wm0 Date: Fri, 13 May 2011 10:19:52 +0100 Message-ID: <382e69$cvag6s@azsmga001.ch.intel.com> References: <1305235044-9159-1-git-send-email-chris@chris-wilson.co.uk> <1305235044-9159-7-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 2666D9E7A4 for ; Fri, 13 May 2011 02:19:56 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 12 May 2011 17:34:49 -0700, Keith Packard wrote: > On Thu, 12 May 2011 22:17:14 +0100, Chris Wilson wrote: > > The computation of the first-level watermarks for g4x and gen5+ are > > based on the same algorithm, so we can refactor those code paths to > > use a single function. > > g4x_compute_wm0 takes a plane. ironlake_compute_wm0 takes a pipe. The > change implicitly assumes that pipe == plane on ironlake. Please clarify? We lucked out. It should have been a plane on Ironlake as well. Fortunately on ILK+ each pipe is slaved to one (identically numbered) plane. -Chris -- Chris Wilson, Intel Open Source Technology Centre