From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "Jerin Jacob" <jerinjacobk@gmail.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
dpdk-dev <dev@dpdk.org>,
techboard@dpdk.org, "Jim St. Leger" <jim.st.leger@intel.com>
Subject: Re: [dpdk-dev] [dpdk-techboard] Consider improving the DPDKcontribution processes
Date: Tue, 26 May 2020 14:45:04 +0200 [thread overview]
Message-ID: <3833724.BKe9lYeCVe@thomas> (raw)
In-Reply-To: <a31ee6b5-3de0-cd2e-f81c-c8e988262ef9@intel.com>
26/05/2020 12:52, Burakov, Anatoly:
> On 26-May-20 11:33 AM, Thomas Monjalon wrote:
>
> >>> And therein lies the problem: Thomas (David, etc.) doesn't look at every
> >>> area of the code, he relies on us to do it. However, *he* is doing the
> >>> committing, and fixing up patches, etc. - so, i can't really say things
> >>> like, "hey, your indentation's wrong here, but Thomas will fix it on
> >>> apply" because that's me pushing more work onto Thomas, something i
> >>> don't think i have the moral right to do :)
> >
> > You can send a new version of the patch with the details fixed,
> > publicly readable, reviewable, and ready to be pushed.
>
> To be completely honest, that's something that's never occurred to me,
> and it sounds like a great idea. The downside is that taking over
> someone else's patch and resubmitting it may be taken the wrong way :)
> (and could also lead to confusion e.g. regarding versioning)
It happens to me to continuing work started by someone else.
I keep original authorship, add my Signed-off-by, increment versioning,
and insert it in the original thread with --in-reply-to.
next prev parent reply other threads:[~2020-05-26 12:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 9:34 [dpdk-dev] Consider improving the DPDK contribution processes Morten Brørup
2020-05-25 11:00 ` Jerin Jacob
2020-05-25 11:12 ` Burakov, Anatoly
2020-05-25 11:58 ` Jerin Jacob
2020-05-25 12:53 ` Thomas Monjalon
2020-05-25 14:28 ` Burakov, Anatoly
2020-05-25 14:55 ` Wiles, Keith
2020-05-25 15:22 ` Thomas Monjalon
2020-05-25 15:35 ` Jerin Jacob
2020-05-25 15:52 ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
2020-05-25 15:59 ` Burakov, Anatoly
2020-05-25 16:04 ` Maxime Coquelin
2020-05-25 16:09 ` Burakov, Anatoly
2020-05-25 16:28 ` Thomas Monjalon
2020-05-25 16:57 ` Wiles, Keith
2020-05-25 17:32 ` Thomas Monjalon
2020-05-25 17:50 ` Wiles, Keith
[not found] ` <068c6367-b233-07f9-c038-4bddc4f48106@kth.se>
2020-05-26 9:33 ` Burakov, Anatoly
2020-05-26 13:12 ` Wiles, Keith
2020-05-26 13:10 ` Wiles, Keith
2020-05-25 18:44 ` [dpdk-dev] [dpdk-techboard] Consider improving the DPDKcontribution processes Morten Brørup
2020-05-25 20:34 ` Thomas Monjalon
2020-05-26 7:06 ` Tom Barbette
2020-05-26 7:31 ` Maxime Coquelin
2020-05-26 9:13 ` Burakov, Anatoly
2020-05-26 9:43 ` Burakov, Anatoly
2020-05-26 10:16 ` Jerin Jacob
2020-05-26 10:33 ` Thomas Monjalon
2020-05-26 10:52 ` Burakov, Anatoly
2020-05-26 12:45 ` Thomas Monjalon [this message]
2020-05-26 13:57 ` Burakov, Anatoly
2020-05-26 14:01 ` Thomas Monjalon
2020-05-26 10:53 ` Jerin Jacob
2020-05-25 16:01 ` [dpdk-dev] [dpdk-techboard] Consider improving the DPDK contribution processes Jerin Jacob
2020-05-25 15:43 ` [dpdk-dev] " Burakov, Anatoly
2020-05-25 14:55 ` Wiles, Keith
2020-05-25 12:08 ` [dpdk-dev] [dpdk-techboard] " Bruce Richardson
2020-05-25 15:04 ` Burakov, Anatoly
2020-05-25 15:28 ` Jerin Jacob
2020-05-25 15:47 ` Stephen Hemminger
2020-05-25 16:21 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3833724.BKe9lYeCVe@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=jim.st.leger@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.