Re: [PATCH v2 1/1] mtd: mtdram: Add parameter for setting writebuf size

[Alexander Stein <alexander.stein@systec-electronic.com>]

On Wednesday 02 March 2016 14:35:55, Bityutskiy, Artem wrote:
> On Wed, 2016-03-02 at 16:32 +0200, Artem Bityutskiy wrote:
> > On Wed, 2016-03-02 at 14:06 +0100, Alexander Stein wrote:
> > > 
> > > +config MTDRAM_WRITEBUF_SIZE
> > > +       int "MTDRAM write buf size in Bytes"
> > > +       depends on MTD_MTDRAM
> > > +       default "64"
> > > +       help
> > > +         This allows you to configure the write buffer size in the
> > > device
> > > +         emulated by the MTDRAM driver.  If the MTDRAM driver is
> > > built
> > > +         as a module, it is also possible to specify this as a
> > > parameter when
> > > +         loading the module. E.g. ubifs relies this in the
> > > recovery
> > > algorithm.
> > Why another Kconfig option (compile-time) instead of just a module
> > parameter (run-time), which would be more flexible?
> 
> Oh, pardon, you are adding both. I never found the Kconfig options very
> useful. Quite the opposite, I always thought MTD has too many of those
> little Kconfig options and the config menu is too large. I'd suggest to
> only add the runtime option, unless you really need the Kconfig option
> too (why?).

I don't need it. Setting using modprobe is enough for me and a lot more flexible. I just kept it the same way as the other 2 parameters. Even those are rather useless in Kconfig, IMHO. Or do you prefer removing the existing Kconfig options all together and just rely on module parameters?

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
alexander.stein@systec-electronic.com

Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany

Office: +49 (0) 3765 38600-0
Fax:    +49 (0) 3765 38600-4100
 
Managing Directors:
	Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
	Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
	Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010