All of lore.kernel.org
 help / color / mirror / Atom feed
From: fabioestevam@yahoo.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] mx51: Move OTG initialisation for all boards to a single file
Date: Thu, 7 Oct 2010 05:03:49 -0700 (PDT)	[thread overview]
Message-ID: <383990.86918.qm@web51007.mail.re2.yahoo.com> (raw)
In-Reply-To: <20101007074853.GZ28242@pengutronix.de>

Hi Amit,

>  +?? void __iomem *usbother_base;
>  +??? usb_base =  ioremap(MX51_OTG_BASE_ADDR, SZ_4K);

Shouldn't you check whether ioremap failed?

Regards,

Fabio Estevam



      

  reply	other threads:[~2010-10-07 12:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07  0:57 [PATCH 0/3] mxc: mx51: Add support for efikamx nettop Amit Kucheria
2010-10-07  0:58 ` [PATCH 1/3] mx51: add support for genesi " Amit Kucheria
2010-10-07  6:55   ` Uwe Kleine-König
2010-10-07 10:31     ` Amit Kucheria
2010-10-07  0:58 ` [PATCH 2/3] mx51: efikamx: add otg support Amit Kucheria
2010-10-07  6:59   ` Uwe Kleine-König
2010-10-07 11:22   ` Sergei Shtylyov
2010-10-07  0:58 ` [PATCH 3/3] mx51: Move OTG initialisation for all boards to a single file Amit Kucheria
2010-10-07  7:08   ` Uwe Kleine-König
2010-10-07 12:04     ` Amit Kucheria
2010-10-07 12:22       ` Uwe Kleine-König
2010-10-07  7:48   ` Sascha Hauer
2010-10-07 12:03     ` Fabio Estevam [this message]
2010-10-08  8:27     ` Amit Kucheria
2010-10-11 10:34     ` Amit Kucheria
2010-10-11 13:10       ` Sascha Hauer
2010-10-11 14:08         ` Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=383990.86918.qm@web51007.mail.re2.yahoo.com \
    --to=fabioestevam@yahoo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.