From: Martin Schiller <ms@dev.tdt.de>
To: David Miller <davem@davemloft.net>
Cc: andrew.hendry@gmail.com, edumazet@google.com,
linux-x25@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/x25: add new state X25_STATE_5
Date: Mon, 09 Dec 2019 06:28:53 +0100 [thread overview]
Message-ID: <3841dcf6dab454445da7b225e0d45212@dev.tdt.de> (raw)
In-Reply-To: <20191207.115922.532322440743611081.davem@davemloft.net>
On 2019-12-07 20:59, David Miller wrote:
> From: Martin Schiller <ms@dev.tdt.de>
> Date: Fri, 6 Dec 2019 14:34:18 +0100
>
>> + switch (frametype) {
>> +
>> + case X25_CLEAR_REQUEST:
>
> Please remove this unnecessary empty line.
>
>> + if (!pskb_may_pull(skb, X25_STD_MIN_LEN + 2))
>> + goto out_clear;
>
> A goto path for a single call site? Just inline the operations here.
Well, I was guided by the code style of the other states.
I could add a patch to also clean up the other states.
What do you think?
next prev parent reply other threads:[~2019-12-09 5:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 13:34 [PATCH] net/x25: add new state X25_STATE_5 Martin Schiller
2019-12-07 19:59 ` David Miller
2019-12-09 5:28 ` Martin Schiller [this message]
2019-12-09 6:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3841dcf6dab454445da7b225e0d45212@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=andrew.hendry@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.