From: Thomas Monjalon <thomas@monjalon.net>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: stephen@networkplumber.org, dev@dpdk.org
Subject: Re: [PATCH] devtools: add script to find duplicated includes
Date: Sat, 15 Jul 2017 11:44:27 +0200 [thread overview]
Message-ID: <38475944.HgsPK1xuzd@xps> (raw)
In-Reply-To: <C6572B54-D94D-4C2D-A02A-342BB521A39B@intel.com>
14/07/2017 20:43, Wiles, Keith:
> > On Jul 14, 2017, at 1:39 PM, Wiles, Keith <keith.wiles@intel.com> wrote:
> >> On Jul 14, 2017, at 12:07 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> >> +cd $(dirname $(readlink -m $0))/..
> >
> > I tried the script it works, but I am concerned about the ‘cd’ above as it does all of the the repo. I would like to see it do just the directory and sub-directories if a path is given. If I am testing a specific PMD or library then I would not want to do all of the repo.
> >
>
> I was thinking about something like the following:
>
> if [ "$1x" = "x" ]; then
> cd $(dirname $(readlink -m $0))/..
> fi
Yes we can add a parameter to the script.
The parameter would be the path to check, and the default value
is the whole repo.
So the script could be used also for another repo - like pktgen ;)
I'll send a v2
next prev parent reply other threads:[~2017-07-15 9:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 18:55 [PATCH 00/19] cleanup duplicate includes Stephen Hemminger
2017-07-11 18:55 ` [PATCH 01/19] devtools: add simple script to find " Stephen Hemminger
2017-07-11 20:33 ` Thomas Monjalon
2017-07-11 23:05 ` Stephen Hemminger
2017-07-12 6:41 ` Thomas Monjalon
2017-07-12 21:59 ` Stephen Hemminger
2017-07-13 6:56 ` Thomas Monjalon
2017-07-13 12:19 ` Wiles, Keith
2017-07-13 12:36 ` Thomas Monjalon
2017-07-14 15:39 ` Thomas Monjalon
2017-07-14 15:54 ` Thomas Monjalon
2017-07-14 16:17 ` Wiles, Keith
2017-07-14 17:07 ` [PATCH] devtools: add script to find duplicated includes Thomas Monjalon
2017-07-14 18:39 ` Wiles, Keith
2017-07-14 18:43 ` Wiles, Keith
2017-07-15 9:44 ` Thomas Monjalon [this message]
2017-07-15 10:00 ` [PATCH v2] " Thomas Monjalon
2017-08-03 10:06 ` Thomas Monjalon
2017-07-17 11:50 ` [PATCH] " Neil Horman
2017-07-17 13:01 ` Thomas Monjalon
2017-07-11 18:55 ` [PATCH 02/19] eal: remove duplicate includes Stephen Hemminger
2017-07-11 18:55 ` [PATCH 03/19] cmdline: remove duplicate include of errno.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 04/19] distributor: remove duplicate include of rte_compat.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 05/19] lpm: remove duplicate include of errno.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 06/19] cuckoo_hash: remove duplicate include of rte_log.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 07/19] timer: remove duplicate include of rte_per_lcore.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 08/19] bnxt: remove duplicate include of unistd.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 09/19] ixgbe: remove duplicate include of rte_atomic.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 10/19] i40e: " Stephen Hemminger
2017-07-11 18:55 ` [PATCH 11/19] virtio: remove duplicated includes Stephen Hemminger
2017-07-11 18:55 ` [PATCH 12/19] cxgbe: " Stephen Hemminger
2017-07-11 18:55 ` [PATCH 13/19] vmxnet3: remove duplicated include of rte_atomic.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 14/19] dpaa2: remove duplicated includes Stephen Hemminger
2017-07-13 9:38 ` Hemant Agrawal
2017-07-11 18:55 ` [PATCH 15/19] fsmlc: " Stephen Hemminger
2017-07-13 9:39 ` Hemant Agrawal
2017-07-11 18:55 ` [PATCH 16/19] app/proc-info: remove duplicate include Stephen Hemminger
2017-07-11 18:55 ` [PATCH 17/19] app/test-pmd: remove duplicate includes Stephen Hemminger
2017-07-11 18:55 ` [PATCH 18/19] test/test-pipeline: remove duplicate include of rte_per_lcore.h Stephen Hemminger
2017-07-11 18:55 ` [PATCH 19/19] test/test: remove duplicate includes Stephen Hemminger
2017-07-16 15:34 ` [PATCH 00/19] cleanup " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38475944.HgsPK1xuzd@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.