Re: [PULL 0/7] 9p queue 2025-02-06

[Christian Schoenebeck <qemu_oss@crudebyte.com>]

On Thursday, February 6, 2025 7:49:07 PM CET Stefan Hajnoczi wrote:
> On Thu, Feb 6, 2025 at 11:49 AM Christian Schoenebeck
> <qemu_oss@crudebyte.com> wrote:
> >
> > The following changes since commit d922088eb4ba6bc31a99f17b32cf75e59dd306cd:
> >
> >   Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2025-02-03 13:42:02 -0500)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/cschoenebeck/qemu.git tags/pull-9p-20250206
> >
> > for you to fetch changes up to bfa7bf02782dbd996201c90f850ca11730041af1:
> >
> >   MAINTAINERS: Mark me as reviewer only for 9pfs (2025-02-06 17:10:46 +0100)
> >
> > ----------------------------------------------------------------
> >
> > * Greg Kurz steps back as maintainer of 9pfs.
> >
> > * Make multidevs=remap default option (instead of multidevs=warn)
> >   and update documentation related to this option.
> >
> > * Improve tracing (i.e. usefulness of log output content).
> >
> > * Add test cases for accessing a directory after removal.
> >
> > ----------------------------------------------------------------
> > Christian Schoenebeck (6):
> >       9pfs: improve v9fs_walk() tracing
> >       9pfs: make multidevs=remap default
> >       9pfs: improve v9fs_open() tracing
> >       tests/9p: rename test use_after_unlink -> use_file_after_unlink
> >       tests/9p: add use_dir_after_unlink test
> >       tests/9p: extend use_dir_after_unlink test with Treaddir
> 
> The following test failure occurred in the CI system:
> 
> 12/65 qemu:qtest+qtest-x86_64 / qtest-x86_64/qos-test ERROR 14.74s
> killed by signal 6 SIGABRT
> ――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
> stderr:
> Received response 7 (RLERROR) instead of 77 (RUNLINKAT)
> Rlerror has errno 22 (Invalid argument)
> **
> ERROR:../tests/qtest/libqos/virtio-9p-client.c:276:v9fs_req_recv:
> assertion failed (hdr.id == id): (7 == 77)
> (test program exited with status code -6)
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/9065429175
> 
> Please take a look. Thanks!
> 
> Stefan

Hmm, in that test a directory is deleted while still having a directory stream
open (via opendir() call) on it. And that directory removal fails when running
in the Gitlab cloud.

So I guess that means that this is file system dependant behaviour whether or
not it is accepted to delete a directory while still having a dir stream open.

I'll just drop this directory test then.

/Christian

> >
> > Greg Kurz (1):
> >       MAINTAINERS: Mark me as reviewer only for 9pfs
> >
> >  MAINTAINERS                  |  3 +--
> >  hw/9pfs/9p-local.c           |  3 +++
> >  hw/9pfs/9p-util-generic.c    | 50 ++++++++++++++++++++++++++++++++++++++++++++
> >  hw/9pfs/9p-util.h            |  6 ++++++
> >  hw/9pfs/9p.c                 | 45 +++++++++++++++++++++++++++++++++------
> >  hw/9pfs/meson.build          |  1 +
> >  hw/9pfs/trace-events         |  4 ++--
> >  qemu-options.hx              | 49 ++++++++++++++++++++++++-------------------
> >  tests/qtest/virtio-9p-test.c | 50 ++++++++++++++++++++++++++++++++++++++++----
> >  9 files changed, 175 insertions(+), 36 deletions(-)
> >  create mode 100644 hw/9pfs/9p-util-generic.c
> >
> 
>