From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 4/7] VNIC common code
Date: Fri, 07 Nov 2014 16:51:24 +0100
Message-ID: <3857314.dObtBBdJqR@xps13>
References: <1415390747-9532-1-git-send-email-ssujith@cisco.com>
 <1415390747-9532-5-git-send-email-ssujith@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Sujith Sankar <ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1415390747-9532-5-git-send-email-ssujith-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-11-08 01:35, Sujith Sankar:
>  lib/librte_pmd_enic/src/cq_desc.h       |  122 ++++
>  lib/librte_pmd_enic/src/cq_enet_desc.h  |  257 ++++++++
>  lib/librte_pmd_enic/src/rq_enet_desc.h  |   72 +++
>  lib/librte_pmd_enic/src/vnic_cq.c       |  113 ++++
>  lib/librte_pmd_enic/src/vnic_cq.h       |  148 +++++
>  lib/librte_pmd_enic/src/vnic_dev.c      | 1077 +++++++++++++++++++++++++++++++
>  lib/librte_pmd_enic/src/vnic_dev.h      |  198 ++++++
>  lib/librte_pmd_enic/src/vnic_devcmd.h   |  770 ++++++++++++++++++++++
>  lib/librte_pmd_enic/src/vnic_enet.h     |   74 +++
>  lib/librte_pmd_enic/src/vnic_intr.c     |   79 +++
>  lib/librte_pmd_enic/src/vnic_intr.h     |  122 ++++
>  lib/librte_pmd_enic/src/vnic_nic.h      |   84 +++
>  lib/librte_pmd_enic/src/vnic_resource.h |   93 +++
>  lib/librte_pmd_enic/src/vnic_rq.c       |  242 +++++++
>  lib/librte_pmd_enic/src/vnic_rq.h       |  278 ++++++++
>  lib/librte_pmd_enic/src/vnic_rss.c      |   81 +++
>  lib/librte_pmd_enic/src/vnic_rss.h      |   57 ++
>  lib/librte_pmd_enic/src/vnic_stats.h    |   82 +++
>  lib/librte_pmd_enic/src/vnic_wq.c       |  241 +++++++
>  lib/librte_pmd_enic/src/vnic_wq.h       |  279 ++++++++
>  lib/librte_pmd_enic/src/wq_enet_desc.h  |  110 ++++
>  21 files changed, 4579 insertions(+)

What is the status of these files?
Are they copied from somewhere?
Please explain in the commit log.

Could you move them in a subdirectory vnic/ or base/?

Please could you remove the src/ subdirectory level?

Thanks
-- 
Thomas