From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Mon, 01 Jul 2013 14:30:28 +0000 Subject: Re: [PATCH 02/24] drm/rcar-du: Use devm_ioremap_resource() Message-Id: <3858285.CxX1dtqHGo@avalon> List-Id: References: <1372326574-4315-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1372326574-4315-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <51CC386D.30309@cogentembedded.com> In-Reply-To: <51CC386D.30309@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org Hi Sergei, On Thursday 27 June 2013 17:04:45 Sergei Shtylyov wrote: > On 27-06-2013 13:49, Laurent Pinchart wrote: > > Replace the devm_request_mem_region() and devm_ioremap_nocache() calls > > with devm_ioremap_resource(). > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 20 ++------------------ > > 1 file changed, 2 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 003b34e..24ab0ca 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > [...] > > > @@ -129,24 +128,9 @@ static int rcar_du_load(struct drm_device *dev, > > unsigned long flags)> > > /* I/O resources and clocks */ > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > [...] > > > + rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem); > > + if (IS_ERR(rcdu->mmio)) > > > > return -ENOMEM; > > You should return PTR_ERR(rcdu->mmio). Good point, I'll fix that. Thank you. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 02/24] drm/rcar-du: Use devm_ioremap_resource() Date: Mon, 01 Jul 2013 16:30:28 +0200 Message-ID: <3858285.CxX1dtqHGo@avalon> References: <1372326574-4315-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1372326574-4315-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <51CC386D.30309@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <51CC386D.30309@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Sergei Shtylyov Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Sergei, On Thursday 27 June 2013 17:04:45 Sergei Shtylyov wrote: > On 27-06-2013 13:49, Laurent Pinchart wrote: > > Replace the devm_request_mem_region() and devm_ioremap_nocache() calls > > with devm_ioremap_resource(). > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 20 ++------------------ > > 1 file changed, 2 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 003b34e..24ab0ca 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > [...] > > > @@ -129,24 +128,9 @@ static int rcar_du_load(struct drm_device *dev, > > unsigned long flags)> > > /* I/O resources and clocks */ > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > [...] > > > + rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem); > > + if (IS_ERR(rcdu->mmio)) > > > > return -ENOMEM; > > You should return PTR_ERR(rcdu->mmio). Good point, I'll fix that. Thank you. -- Regards, Laurent Pinchart