From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479DCC433EF for ; Tue, 28 Dec 2021 10:26:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234275AbhL1K0o (ORCPT ); Tue, 28 Dec 2021 05:26:44 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:34852 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbhL1K0m (ORCPT ); Tue, 28 Dec 2021 05:26:42 -0500 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JNW0P01swzccD4; Tue, 28 Dec 2021 18:26:13 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 28 Dec 2021 18:26:40 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Tue, 28 Dec 2021 18:26:39 +0800 Message-ID: <3858de1f-cdbc-ff52-2890-4254d0f48b0a@huawei.com> Date: Tue, 28 Dec 2021 18:26:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 From: Kefeng Wang Subject: Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings To: Dave Hansen , Jonathan Corbet , Andrew Morton , , , , , , CC: Nicholas Piggin , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Michael Ellerman , "Benjamin Herrenschmidt" , Paul Mackerras , Christophe Leroy , Matthew Wilcox References: <20211227145903.187152-1-wangkefeng.wang@huawei.com> <20211227145903.187152-4-wangkefeng.wang@huawei.com> <70ff58bc-3a92-55c2-2da8-c5877af72e44@intel.com> Content-Language: en-US In-Reply-To: <70ff58bc-3a92-55c2-2da8-c5877af72e44@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggeme702-chm.china.huawei.com (10.1.199.98) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 2021/12/27 23:56, Dave Hansen wrote: > On 12/27/21 6:59 AM, Kefeng Wang wrote: >> This patch select HAVE_ARCH_HUGE_VMALLOC to let X86_64 and X86_PAE >> support huge vmalloc mappings. > In general, this seems interesting and the diff is simple. But, I don't > see _any_ x86-specific data. I think the bare minimum here would be a > few kernel compiles and some 'perf stat' data for some TLB events. When the feature supported on ppc, commit 8abddd968a303db75e4debe77a3df484164f1f33 Author: Nicholas Piggin Date:   Mon May 3 19:17:55 2021 +1000     powerpc/64s/radix: Enable huge vmalloc mappings     This reduces TLB misses by nearly 30x on a `git diff` workload on a     2-node POWER9 (59,800 -> 2,100) and reduces CPU cycles by 0.54%, due     to vfs hashes being allocated with 2MB pages. But the data could be different on different machine/arch. >> diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c >> index 95fa745e310a..6bf5cb7d876a 100644 >> --- a/arch/x86/kernel/module.c >> +++ b/arch/x86/kernel/module.c >> @@ -75,8 +75,8 @@ void *module_alloc(unsigned long size) >> >> p = __vmalloc_node_range(size, MODULE_ALIGN, >> MODULES_VADDR + get_module_load_offset(), >> - MODULES_END, gfp_mask, >> - PAGE_KERNEL, VM_DEFER_KMEMLEAK, NUMA_NO_NODE, >> + MODULES_END, gfp_mask, PAGE_KERNEL, >> + VM_DEFER_KMEMLEAK | VM_NO_HUGE_VMAP, NUMA_NO_NODE, >> __builtin_return_address(0)); >> if (p && (kasan_module_alloc(p, size, gfp_mask) < 0)) { >> vfree(p); > To figure out what's going on in this hunk, I had to look at the cover > letter (which I wasn't cc'd on). That's not great and it means that > somebody who stumbles upon this in the code is going to have a really > hard time figuring out what is going on. Cover letters don't make it > into git history. Sorry for that, will add more into arch's patch changelog. > This desperately needs a comment and some changelog material in *this* > patch. > > But, even the description from the cover letter is sparse: > >> There are some disadvantages about this feature[2], one of the main >> concerns is the possible memory fragmentation/waste in some scenarios, >> also archs must ensure that any arch specific vmalloc allocations that >> require PAGE_SIZE mappings(eg, module alloc with STRICT_MODULE_RWX) >> use the VM_NO_HUGE_VMAP flag to inhibit larger mappings. > That just says that x86 *needs* PAGE_SIZE allocations. But, what > happens if VM_NO_HUGE_VMAP is not passed (like it was in v1)? Will the > subsequent permission changes just fragment the 2M mapping? > . Yes, without VM_NO_HUGE_VMAP, it could fragment the 2M mapping. When module alloc with STRICT_MODULE_RWX on x86, it calls __change_page_attr() from set_memory_ro/rw/nx which will split large page, so there is no need to make module alloc with HUGE_VMALLOC. > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B67EC433F5 for ; Tue, 28 Dec 2021 10:27:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JNW2G5SVBz2yxL for ; Tue, 28 Dec 2021 21:27:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.187; helo=szxga01-in.huawei.com; envelope-from=wangkefeng.wang@huawei.com; receiver=) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JNW1h1zJJz2yfb for ; Tue, 28 Dec 2021 21:27:17 +1100 (AEDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JNW0P01swzccD4; Tue, 28 Dec 2021 18:26:13 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 28 Dec 2021 18:26:40 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Tue, 28 Dec 2021 18:26:39 +0800 Message-ID: <3858de1f-cdbc-ff52-2890-4254d0f48b0a@huawei.com> Date: Tue, 28 Dec 2021 18:26:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 From: Kefeng Wang Subject: Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings To: Dave Hansen , Jonathan Corbet , Andrew Morton , , , , , , References: <20211227145903.187152-1-wangkefeng.wang@huawei.com> <20211227145903.187152-4-wangkefeng.wang@huawei.com> <70ff58bc-3a92-55c2-2da8-c5877af72e44@intel.com> Content-Language: en-US In-Reply-To: <70ff58bc-3a92-55c2-2da8-c5877af72e44@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggeme702-chm.china.huawei.com (10.1.199.98) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Wilcox , Catalin Marinas , Dave Hansen , Nicholas Piggin , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Paul Mackerras , Thomas Gleixner , Will Deacon Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2021/12/27 23:56, Dave Hansen wrote: > On 12/27/21 6:59 AM, Kefeng Wang wrote: >> This patch select HAVE_ARCH_HUGE_VMALLOC to let X86_64 and X86_PAE >> support huge vmalloc mappings. > In general, this seems interesting and the diff is simple. But, I don't > see _any_ x86-specific data. I think the bare minimum here would be a > few kernel compiles and some 'perf stat' data for some TLB events. When the feature supported on ppc, commit 8abddd968a303db75e4debe77a3df484164f1f33 Author: Nicholas Piggin Date:   Mon May 3 19:17:55 2021 +1000     powerpc/64s/radix: Enable huge vmalloc mappings     This reduces TLB misses by nearly 30x on a `git diff` workload on a     2-node POWER9 (59,800 -> 2,100) and reduces CPU cycles by 0.54%, due     to vfs hashes being allocated with 2MB pages. But the data could be different on different machine/arch. >> diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c >> index 95fa745e310a..6bf5cb7d876a 100644 >> --- a/arch/x86/kernel/module.c >> +++ b/arch/x86/kernel/module.c >> @@ -75,8 +75,8 @@ void *module_alloc(unsigned long size) >> >> p = __vmalloc_node_range(size, MODULE_ALIGN, >> MODULES_VADDR + get_module_load_offset(), >> - MODULES_END, gfp_mask, >> - PAGE_KERNEL, VM_DEFER_KMEMLEAK, NUMA_NO_NODE, >> + MODULES_END, gfp_mask, PAGE_KERNEL, >> + VM_DEFER_KMEMLEAK | VM_NO_HUGE_VMAP, NUMA_NO_NODE, >> __builtin_return_address(0)); >> if (p && (kasan_module_alloc(p, size, gfp_mask) < 0)) { >> vfree(p); > To figure out what's going on in this hunk, I had to look at the cover > letter (which I wasn't cc'd on). That's not great and it means that > somebody who stumbles upon this in the code is going to have a really > hard time figuring out what is going on. Cover letters don't make it > into git history. Sorry for that, will add more into arch's patch changelog. > This desperately needs a comment and some changelog material in *this* > patch. > > But, even the description from the cover letter is sparse: > >> There are some disadvantages about this feature[2], one of the main >> concerns is the possible memory fragmentation/waste in some scenarios, >> also archs must ensure that any arch specific vmalloc allocations that >> require PAGE_SIZE mappings(eg, module alloc with STRICT_MODULE_RWX) >> use the VM_NO_HUGE_VMAP flag to inhibit larger mappings. > That just says that x86 *needs* PAGE_SIZE allocations. But, what > happens if VM_NO_HUGE_VMAP is not passed (like it was in v1)? Will the > subsequent permission changes just fragment the 2M mapping? > . Yes, without VM_NO_HUGE_VMAP, it could fragment the 2M mapping. When module alloc with STRICT_MODULE_RWX on x86, it calls __change_page_attr() from set_memory_ro/rw/nx which will split large page, so there is no need to make module alloc with HUGE_VMALLOC. > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E78CC433EF for ; Tue, 28 Dec 2021 10:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:CC:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KNv1v/AIqQphTSHWXhbrWodl9lo2cISjsLM0ds8cCpU=; b=CyGieOjkWeYWGb uZXtMytW/zy815rxYf5ryxsow24ZznncDD3TS4eOtnVXwl1RTki52UuRWTnGV2oK9w/eKXwNv7ktN Ew2yvxEUxziQc5ws0XyRbrt7h0ba3w+GtOlSDUjRp/xp1jXfPrzSIjz9CRDMaQBZ5wxIBDfi5wH6o 33h7oXFKGLzGsOD3A2I/8CRO59Z41FJ6aDY93IeQzjBVXsBmRxQrxlDSfuhBXO0YHp04MB2oOlfft eToWWh5B7FYdw31doJ3X/3sgR/xJ7mrUBoHSaKcAw6ou3QEj3mmEAjkMcKTfFu12H3fABHk7DqSoW vVbxtVf0DmHsCj7+ERZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n29gu-000gBq-F0; Tue, 28 Dec 2021 10:26:48 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n29gq-000gAg-89 for linux-arm-kernel@lists.infradead.org; Tue, 28 Dec 2021 10:26:46 +0000 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JNW0P01swzccD4; Tue, 28 Dec 2021 18:26:13 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 28 Dec 2021 18:26:40 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Tue, 28 Dec 2021 18:26:39 +0800 Message-ID: <3858de1f-cdbc-ff52-2890-4254d0f48b0a@huawei.com> Date: Tue, 28 Dec 2021 18:26:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 From: Kefeng Wang Subject: Re: [PATCH v2 3/3] x86: Support huge vmalloc mappings To: Dave Hansen , Jonathan Corbet , Andrew Morton , , , , , , CC: Nicholas Piggin , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Michael Ellerman , "Benjamin Herrenschmidt" , Paul Mackerras , Christophe Leroy , Matthew Wilcox References: <20211227145903.187152-1-wangkefeng.wang@huawei.com> <20211227145903.187152-4-wangkefeng.wang@huawei.com> <70ff58bc-3a92-55c2-2da8-c5877af72e44@intel.com> Content-Language: en-US In-Reply-To: <70ff58bc-3a92-55c2-2da8-c5877af72e44@intel.com> X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggeme702-chm.china.huawei.com (10.1.199.98) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211228_022644_639578_51866B8B X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjEvMTIvMjcgMjM6NTYsIERhdmUgSGFuc2VuIHdyb3RlOgo+IE9uIDEyLzI3LzIxIDY6 NTkgQU0sIEtlZmVuZyBXYW5nIHdyb3RlOgo+PiBUaGlzIHBhdGNoIHNlbGVjdCBIQVZFX0FSQ0hf SFVHRV9WTUFMTE9DIHRvIGxldCBYODZfNjQgYW5kIFg4Nl9QQUUKPj4gc3VwcG9ydCBodWdlIHZt YWxsb2MgbWFwcGluZ3MuCj4gSW4gZ2VuZXJhbCwgdGhpcyBzZWVtcyBpbnRlcmVzdGluZyBhbmQg dGhlIGRpZmYgaXMgc2ltcGxlLiAgQnV0LCBJIGRvbid0Cj4gc2VlIF9hbnlfIHg4Ni1zcGVjaWZp YyBkYXRhLiAgSSB0aGluayB0aGUgYmFyZSBtaW5pbXVtIGhlcmUgd291bGQgYmUgYQo+IGZldyBr ZXJuZWwgY29tcGlsZXMgYW5kIHNvbWUgJ3BlcmYgc3RhdCcgZGF0YSBmb3Igc29tZSBUTEIgZXZl bnRzLgoKV2hlbiB0aGUgZmVhdHVyZSBzdXBwb3J0ZWQgb24gcHBjLAoKY29tbWl0IDhhYmRkZDk2 OGEzMDNkYjc1ZTRkZWJlNzdhM2RmNDg0MTY0ZjFmMzMKQXV0aG9yOiBOaWNob2xhcyBQaWdnaW4g PG5waWdnaW5AZ21haWwuY29tPgpEYXRlOsKgwqAgTW9uIE1heSAzIDE5OjE3OjU1IDIwMjEgKzEw MDAKCiDCoMKgwqAgcG93ZXJwYy82NHMvcmFkaXg6IEVuYWJsZSBodWdlIHZtYWxsb2MgbWFwcGlu Z3MKCiDCoMKgwqAgVGhpcyByZWR1Y2VzIFRMQiBtaXNzZXMgYnkgbmVhcmx5IDMweCBvbiBhIGBn aXQgZGlmZmAgd29ya2xvYWQgb24gYQogwqDCoMKgIDItbm9kZSBQT1dFUjkgKDU5LDgwMCAtPiAy LDEwMCkgYW5kIHJlZHVjZXMgQ1BVIGN5Y2xlcyBieSAwLjU0JSwgZHVlCiDCoMKgwqAgdG8gdmZz IGhhc2hlcyBiZWluZyBhbGxvY2F0ZWQgd2l0aCAyTUIgcGFnZXMuCgpCdXQgdGhlIGRhdGEgY291 bGQgYmUgZGlmZmVyZW50IG9uIGRpZmZlcmVudCBtYWNoaW5lL2FyY2guCgo+PiBkaWZmIC0tZ2l0 IGEvYXJjaC94ODYva2VybmVsL21vZHVsZS5jIGIvYXJjaC94ODYva2VybmVsL21vZHVsZS5jCj4+ IGluZGV4IDk1ZmE3NDVlMzEwYS4uNmJmNWNiN2Q4NzZhIDEwMDY0NAo+PiAtLS0gYS9hcmNoL3g4 Ni9rZXJuZWwvbW9kdWxlLmMKPj4gKysrIGIvYXJjaC94ODYva2VybmVsL21vZHVsZS5jCj4+IEBA IC03NSw4ICs3NSw4IEBAIHZvaWQgKm1vZHVsZV9hbGxvYyh1bnNpZ25lZCBsb25nIHNpemUpCj4+ ICAgCj4+ICAgCXAgPSBfX3ZtYWxsb2Nfbm9kZV9yYW5nZShzaXplLCBNT0RVTEVfQUxJR04sCj4+ ICAgCQkJCSAgICBNT0RVTEVTX1ZBRERSICsgZ2V0X21vZHVsZV9sb2FkX29mZnNldCgpLAo+PiAt CQkJCSAgICBNT0RVTEVTX0VORCwgZ2ZwX21hc2ssCj4+IC0JCQkJICAgIFBBR0VfS0VSTkVMLCBW TV9ERUZFUl9LTUVNTEVBSywgTlVNQV9OT19OT0RFLAo+PiArCQkJCSAgICBNT0RVTEVTX0VORCwg Z2ZwX21hc2ssIFBBR0VfS0VSTkVMLAo+PiArCQkJCSAgICBWTV9ERUZFUl9LTUVNTEVBSyB8IFZN X05PX0hVR0VfVk1BUCwgTlVNQV9OT19OT0RFLAo+PiAgIAkJCQkgICAgX19idWlsdGluX3JldHVy bl9hZGRyZXNzKDApKTsKPj4gICAJaWYgKHAgJiYgKGthc2FuX21vZHVsZV9hbGxvYyhwLCBzaXpl LCBnZnBfbWFzaykgPCAwKSkgewo+PiAgIAkJdmZyZWUocCk7Cj4gVG8gZmlndXJlIG91dCB3aGF0 J3MgZ29pbmcgb24gaW4gdGhpcyBodW5rLCBJIGhhZCB0byBsb29rIGF0IHRoZSBjb3Zlcgo+IGxl dHRlciAod2hpY2ggSSB3YXNuJ3QgY2MnZCBvbikuICBUaGF0J3Mgbm90IGdyZWF0IGFuZCBpdCBt ZWFucyB0aGF0Cj4gc29tZWJvZHkgd2hvIHN0dW1ibGVzIHVwb24gdGhpcyBpbiB0aGUgY29kZSBp cyBnb2luZyB0byBoYXZlIGEgcmVhbGx5Cj4gaGFyZCB0aW1lIGZpZ3VyaW5nIG91dCB3aGF0IGlz IGdvaW5nIG9uLiAgQ292ZXIgbGV0dGVycyBkb24ndCBtYWtlIGl0Cj4gaW50byBnaXQgaGlzdG9y eS4KU29ycnkgZm9yIHRoYXQsIHdpbGwgYWRkIG1vcmUgaW50byBhcmNoJ3MgcGF0Y2ggY2hhbmdl bG9nLgo+IFRoaXMgZGVzcGVyYXRlbHkgbmVlZHMgYSBjb21tZW50IGFuZCBzb21lIGNoYW5nZWxv ZyBtYXRlcmlhbCBpbiAqdGhpcyoKPiBwYXRjaC4KPgo+IEJ1dCwgZXZlbiB0aGUgZGVzY3JpcHRp b24gZnJvbSB0aGUgY292ZXIgbGV0dGVyIGlzIHNwYXJzZToKPgo+PiBUaGVyZSBhcmUgc29tZSBk aXNhZHZhbnRhZ2VzIGFib3V0IHRoaXMgZmVhdHVyZVsyXSwgb25lIG9mIHRoZSBtYWluCj4+IGNv bmNlcm5zIGlzIHRoZSBwb3NzaWJsZSBtZW1vcnkgZnJhZ21lbnRhdGlvbi93YXN0ZSBpbiBzb21l IHNjZW5hcmlvcywKPj4gYWxzbyBhcmNocyBtdXN0IGVuc3VyZSB0aGF0IGFueSBhcmNoIHNwZWNp ZmljIHZtYWxsb2MgYWxsb2NhdGlvbnMgdGhhdAo+PiByZXF1aXJlIFBBR0VfU0laRSBtYXBwaW5n cyhlZywgbW9kdWxlIGFsbG9jIHdpdGggU1RSSUNUX01PRFVMRV9SV1gpCj4+IHVzZSB0aGUgVk1f Tk9fSFVHRV9WTUFQIGZsYWcgdG8gaW5oaWJpdCBsYXJnZXIgbWFwcGluZ3MuCj4gVGhhdCBqdXN0 IHNheXMgdGhhdCB4ODYgKm5lZWRzKiBQQUdFX1NJWkUgYWxsb2NhdGlvbnMuICBCdXQsIHdoYXQK PiBoYXBwZW5zIGlmIFZNX05PX0hVR0VfVk1BUCBpcyBub3QgcGFzc2VkIChsaWtlIGl0IHdhcyBp biB2MSk/ICBXaWxsIHRoZQo+IHN1YnNlcXVlbnQgcGVybWlzc2lvbiBjaGFuZ2VzIGp1c3QgZnJh Z21lbnQgdGhlIDJNIG1hcHBpbmc/Cj4gLgoKWWVzLCB3aXRob3V0IFZNX05PX0hVR0VfVk1BUCwg aXQgY291bGQgZnJhZ21lbnQgdGhlIDJNIG1hcHBpbmcuCgpXaGVuIG1vZHVsZSBhbGxvYyB3aXRo IFNUUklDVF9NT0RVTEVfUldYIG9uIHg4NiwgaXQgY2FsbHMgCl9fY2hhbmdlX3BhZ2VfYXR0cigp Cgpmcm9tIHNldF9tZW1vcnlfcm8vcncvbnggd2hpY2ggd2lsbCBzcGxpdCBsYXJnZSBwYWdlLCBz byB0aGVyZSBpcyBubyAKbmVlZCB0byBtYWtlCgptb2R1bGUgYWxsb2Mgd2l0aCBIVUdFX1ZNQUxM T0MuCgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKPgo+ICAgICAgCj4gICAg ICAKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=