From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 0/6 v4] adv7511 EDID probing improvements Date: Thu, 19 Jan 2017 01:04:02 +0200 Message-ID: <3859476.cEhDXg5Hko@avalon> References: <1484614372-15342-1-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BB076E2E3 for ; Wed, 18 Jan 2017 23:03:44 +0000 (UTC) In-Reply-To: <1484614372-15342-1-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: lkml , dri-devel@lists.freedesktop.org, Wolfram Sang List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoZXMuCgpPbiBNb25kYXkgMTYgSmFuIDIw MTcgMTY6NTI6NDYgSm9obiBTdHVsdHogd3JvdGU6Cj4gV2FudGVkIHRvIHJlLXNlbmQgb3V0IHY0 ICBvZiB0aGlzIHBhdGNoIHNldCwgaW50ZWdyYXRpbmcgc29tZQo+IGNoYW5nZXMgc3VnZ2VzdGVk IGJ5IExhdXJlbnQsIGZvciBjb25zaWRlcmF0aW9uIGZvciBtZXJnaW5nIGZvcgo+IHY0LjExCj4g Cj4gVGhlIGZpcnN0IHRocmVlIHBhdGNoZXMgYXJlIGZpeHVwcyB0aGF0IGFyZSBob3BlZnVsbHkg c3RyYWlnaHQKPiBmb3J3YXJkLCBpbnRlZ3JhdGluZyBmZWVkYmFjayBJIGdvdCBmcm9tIExhdXJh bnQsIHdpdGggbWluaW1hbAo+IGNoYW5nZSBmcm9tIHRoZSBwcmV2aW91cyB2ZXJzaW9ucy4KPiAK PiBUaGUgbGFzdCB0aHJlZSBwYXRjaGVzIHRyeSB0byBjbGVhbiB1cCBhbmQgcmV3b3JrIHRoZSBF RElECj4gcHJvYmluZyBjb2RlLCB0byBhdm9pZCBpc3N1ZXMgc2VlbiBvbiBIaUtleS4gSSd2ZSBy ZXdvcmtlZCB0aGVzZQo+IG1vcmUgc2lnbmlmaWNhbnRseSBzaW5jZSB2MyB0byBhZGRyZXNzIGZl ZWRiYWNrIGZyb20gTGF1cmVudC4KPiAKPiBUaG91Z2h0cyBhbmQgZmVlZGJhY2sgd291bGQgYmUg YXBwcmVjaWF0ZWQhCgpGb3IgdGhlIHdob2xlIHNlcmllcywKClRlc3RlZC1ieTogTGF1cmVudCBQ aW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiBOZXcgaW4gdjQ6 Cj4gKiBUd2Vha2VkIGNvbm5lY3Rvci5zdGF0dXMgYXNzaWdubWVudCB0byBhdm9pZCByYWNlLCBh cwo+ICAgc3VnZ2VzdGVkIGJ5IExhdXJlbnQKPiAqIFJld29ya2VkIHRoZSBfX2Fkdjc1MTFfcG93 ZXJfb24gaGVscGVycyB0byBhdm9pZCBjYWxsaW5nCj4gICByZWdjYWNoZV9zeW5jIGluIHRoZSBF RElEIHByb2JlIHBhdGgKPiAqIEFkZGVkIG5ldyBwYXRjaCB0byBzZXQgRURJRF9JMkNfQUREUiBy ZWdpc3RlciBiZWZvcmUgZG9pbmcKPiAgIEVESUQgcmVhZC4KPiAKPiBDYzogRGF2aWQgQWlybGll IDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVhdXJv cmEub3JnPgo+IENjOiBXb2xmcmFtIFNhbmcgPHdzYStyZW5lc2FzQHNhbmctZW5naW5lZXJpbmcu Y29tPgo+IENjOiBMYXJzLVBldGVyIENsYXVzZW4gPGxhcnNAbWV0YWZvby5kZT4KPiBDYzogTGF1 cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IENjOiBk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gCj4gQXJjaGl0IFRhbmVqYSAoMSk6Cj4g ICBkcm0vYnJpZGdlOiBhZHY3NTExOiBFbmFibGUgSFBEIGludGVycnVwdHMgdG8gc3VwcG9ydCBo b3RwbHVnIGFuZAo+ICAgICBpbXByb3ZlIG1vbml0b3IgZGV0ZWN0aW9uCj4gCj4gSm9obiBTdHVs dHogKDUpOgo+ICAgZHJtL2JyaWRnZTogYWR2NzUxMTogVXNlIHdvcmtfc3RydWN0IHRvIGRlZmVy IGhvdHBsdWcgaGFuZGluZyB0byBvdXQKPiAgICAgb2YgaXJxIGNvbnRleHQKPiAgIGRybS9icmlk Z2U6IGFkdjc1MTE6IFN3aXRjaCB0byB1c2luZyBkcm1fa21zX2hlbHBlcl9ob3RwbHVnX2V2ZW50 KCkKPiAgIGRybS9icmlkZ2U6IGFkdjc1MTE6IFJld29yayBhZHY3NTExX3Bvd2VyX29uL29mZigp IHNvIHRoZXkgY2FuIGJlCj4gICAgIHJldXNlZCBpbnRlcm5hbGx5Cj4gICBkcm0vYnJpZGdlOiBh ZHY3NTExOiBSZXVzZSBfX2Fkdjc1MTFfcG93ZXJfb24vb2ZmKCkgd2hlbiBwcm9iaW5nIEVESUQK PiAgIGRybS9icmlkZ2U6IGFkdjc1MTE6IFJlLXdyaXRlIHRoZSBpMmMgYWRkcmVzcyBiZWZvcmUg RURJRCBwcm9iaW5nCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTEx LmggICAgIHwgIDIgKwo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMV9k cnYuYyB8IDY3Cj4gKysrKysrKysrKysrKysrKysrKystLS0tLS0tLSAyIGZpbGVzIGNoYW5nZWQs IDUxIGluc2VydGlvbnMoKyksIDE4Cj4gZGVsZXRpb25zKC0pCgotLSAKUmVnYXJkcywKCkxhdXJl bnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751213AbdARXEy (ORCPT ); Wed, 18 Jan 2017 18:04:54 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:45592 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbdARXEx (ORCPT ); Wed, 18 Jan 2017 18:04:53 -0500 From: Laurent Pinchart To: John Stultz Cc: lkml , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/6 v4] adv7511 EDID probing improvements Date: Thu, 19 Jan 2017 01:04:02 +0200 Message-ID: <3859476.cEhDXg5Hko@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1484614372-15342-1-git-send-email-john.stultz@linaro.org> References: <1484614372-15342-1-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, Thank you for the patches. On Monday 16 Jan 2017 16:52:46 John Stultz wrote: > Wanted to re-send out v4 of this patch set, integrating some > changes suggested by Laurent, for consideration for merging for > v4.11 > > The first three patches are fixups that are hopefully straight > forward, integrating feedback I got from Laurant, with minimal > change from the previous versions. > > The last three patches try to clean up and rework the EDID > probing code, to avoid issues seen on HiKey. I've reworked these > more significantly since v3 to address feedback from Laurent. > > Thoughts and feedback would be appreciated! For the whole series, Tested-by: Laurent Pinchart > New in v4: > * Tweaked connector.status assignment to avoid race, as > suggested by Laurent > * Reworked the __adv7511_power_on helpers to avoid calling > regcache_sync in the EDID probe path > * Added new patch to set EDID_I2C_ADDR register before doing > EDID read. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > > Archit Taneja (1): > drm/bridge: adv7511: Enable HPD interrupts to support hotplug and > improve monitor detection > > John Stultz (5): > drm/bridge: adv7511: Use work_struct to defer hotplug handing to out > of irq context > drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() > drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be > reused internally > drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID > drm/bridge: adv7511: Re-write the i2c address before EDID probing > > drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 + > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 67 > ++++++++++++++++++++-------- 2 files changed, 51 insertions(+), 18 > deletions(-) -- Regards, Laurent Pinchart