From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Tue, 16 Apr 2013 09:09:42 +0000 Subject: Re: [PATCH] sh-pfc: R8A7779: add VIN pin groups Message-Id: <3861427.7X66IM5gtB@avalon> List-Id: References: <201304120251.38652.sergei.shtylyov@cogentembedded.com> In-Reply-To: <201304120251.38652.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Sergei, On Friday 12 April 2013 18:26:20 Sergei Shtylyov wrote: > On 12-04-2013 8:33, Kuninori Morimoto wrote: > > Thank you for your patch > > It's not mine. :-) > > >> +/* - VIN0 > >> ------------------------------------------------------------------- */ > >> +static const unsigned int vin0_data8_pins[] = { > >> + /* D[0:7] */ > >> + 70, 71, 72, 73, 74, 75, 76, 77, > >> +}; > > > > Can you use RCAR_GP_PIN() macro on this patch ? > > > > 0bd898b16cdc0a4512d0b1af2fbe1174d217dd2d > > (gpio-rcar: Add RCAR_GP_PIN macro) > > I think there should be a wholesale conversion patch for all this file. The whole file has been converted already in tags/renesas-next-20130416. Could you please rebase this patch on top of that tag and resubmit, with the hardcoded pin numbers replaced with the RCAR_GP_PIN() macro ? -- Regards, Laurent Pinchart