From: Thomas Monjalon <thomas@monjalon.net>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
remy.horton@intel.com
Cc: dev@dpdk.org, john.mcnamara@intel.com, jasvinder.singh@intel.com,
radu.nicolau@intel.com, david.hunt@intel.com
Subject: Re: [PATCH] doc: API change notice for librte_meter
Date: Fri, 04 Aug 2017 16:28:46 +0200 [thread overview]
Message-ID: <3871111.0JZd9azV8i@xps> (raw)
In-Reply-To: <1501852780-191124-1-git-send-email-cristian.dumitrescu@intel.com>
04/08/2017 15:19, Cristian Dumitrescu:
> +* librte_meter: The API will change to accommodate configuration profiles.
> + Most of the API functions will have an additional opaque parameter.
Why?
Why opaque parameter?
If you want to use it with a configuration file, you just have to
implement a configuration file in your application.
Moreover, I already explained my fear of adding this library in DPDK
which is really an application-level statistics lib.
Without more explanations, my vote is a nack.
However I remember there was a promise to merge every metrics libs in one.
next prev parent reply other threads:[~2017-08-04 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 13:19 [PATCH] doc: API change notice for librte_meter Cristian Dumitrescu
2017-08-04 14:28 ` Thomas Monjalon [this message]
2017-08-04 14:38 ` Dumitrescu, Cristian
2017-08-04 14:48 ` Thomas Monjalon
2017-08-04 15:04 ` Dumitrescu, Cristian
2017-08-04 15:16 ` Thomas Monjalon
2017-08-08 10:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3871111.0JZd9azV8i@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
--cc=radu.nicolau@intel.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.