From: Dmitry Osipenko <digetx@gmail.com>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH 01/28] ARM: tegra: apalis_t30: enable broken-hpi on emmc
Date: Tue, 24 Jul 2018 17:55:14 +0300 [thread overview]
Message-ID: <3879609.rmqHIZXFHx@dimapc> (raw)
In-Reply-To: <1532442416.6124.28.camel@toradex.com>
On Tuesday, 24 July 2018 17:26:58 MSK Marcel Ziswiler wrote:
> On Tue, 2018-07-24 at 17:03 +0300, Dmitry Osipenko wrote:
>
> > On Sunday, 22 July 2018 19:49:09 MSK Marcel Ziswiler wrote:
> >
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > Avoid eMMC issues by specifying broken-hpi.
> > >
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > ---
> >
> >
> > Is it a specific eMMC card model that has broken HPI or it is a host
> > controller bug?
>
>
> That is a very good question. So far we only have confirmation that at
> least some eMMCs from Hynix resp. SKHynix definitely do have bad
> firmware. I also found out that ASUS resp. Google did disable HPI on
> their Nexus 7 tablet. Therefore, we also disabled HPI quite a while ago
> in our downstream BSPs which we successfully validated & verified doing
> power cuts and running stress tests in our temperature chambers. I
> guess we would have to run more extensive tests with mainline with and
> without this setting to be able to really answer your question. For now
> I just successfully run a few Apalis T30 and Colibri T30 modules with
> this setting over the weekend doing both hdparm -t as well as dding
> some urandom files to the eMMC in a loop without seeing any issues.
The broken-hpi quirk was added for the Hynix cards specifically in [0]. Maybe
you should just extend the mmc_ext_csd_fixups list in [1] with another OEM ID?
[0] https://patchwork.kernel.org/patch/9168455/
[1] drivers/mmc/core/quirks.h
next prev parent reply other threads:[~2018-07-24 14:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-22 16:49 [PATCH 00/28] ARM: dts: tegra: apalis_t30: major revamp incl. v1.1 hardware support Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 01/28] ARM: tegra: apalis_t30: enable broken-hpi on emmc Marcel Ziswiler
2018-07-24 14:03 ` Dmitry Osipenko
2018-07-24 14:26 ` Marcel Ziswiler
2018-07-24 14:55 ` Dmitry Osipenko [this message]
2018-07-25 8:40 ` Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 02/28] ARM: tegra: apalis_t30: fix mmc1 cmd pull-up Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 03/28] ARM: tegra: apalis_t30: pull-up sd card detect pins Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 04/28] ARM: tegra: apalis_t30: add local-mac-address property Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 05/28] ARM: tegra: apalis_t30: reorder pcie properties Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 06/28] ARM: tegra: apalis_t30: annotate pcie port nodes Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 07/28] ARM: tegra: apalis_t30: reorder host1x/hdmi properties Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 08/28] ARM: tegra: apalis_t30: regulator clean-up Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 09/28] ARM: tegra: apalis_t30: add missing regulators Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 10/28] ARM: tegra: apalis_t30: annotate uarts Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 11/28] ARM: tegra: apalis_t30: drop unused cami2c label Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 12/28] ARM: tegra: apalis_t30: white-space clean-up Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 13/28] ARM: tegra: apalis_t30: drop unused mmc1/sd1 labels Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 14/28] ARM: tegra: apalis_t30: annotate mmc1/sd1 Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 15/28] ARM: tegra: apalis_t30: move dr_mode property from phy to controller Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 16/28] ARM: tegra: apalis_t30: reorder backlight properties Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 17/28] ARM: tegra: apalis_t30: drop pwmleds Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 18/28] ARM: tegra: apalis_t30: pinmux clean-up Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 19/28] ARM: tegra: apalis_t30: add missing pinmux Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 20/28] ARM: tegra: apalis_t30: use proper irq-gpio for stmpe811 Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 21/28] ARM: tegra: apalis_t30: further lm95245 temperature sensor annotation Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 22/28] ARM: tegra: apalis_t30: add i2c-thermtrip Marcel Ziswiler
2018-07-25 11:11 ` Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 23/28] ARM: tegra: apalis_t30: add proper emmc vmmc and vqmmc supplies Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 24/28] ARM: tegra: apalis_t30: enable emmc ddr52 mode Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 25/28] ARM: tegra: apalis_t30: rename clk to clock Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 26/28] ARM: tegra: apalis_t30: line break long compatible property line Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 27/28] ARM: tegra: apalis_t30: fix pcie switch vendor compatible Marcel Ziswiler
2018-07-22 16:49 ` [PATCH 28/28] ARM: tegra: apalis_t30: support v1.1 hardware revision Marcel Ziswiler
2018-07-31 21:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3879609.rmqHIZXFHx@dimapc \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.