From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>, y2038@lists.linaro.org
Subject: Re: [Outreachy kernel] Re: [Y2038] [PATCH] char: ipmi: ipmi_ssif: Replace timeval with timespec64
Date: Fri, 23 Oct 2015 21:34:57 +0200 [thread overview]
Message-ID: <3885032.B7rTY3eIDR@wuerfel> (raw)
In-Reply-To: <CA+5yK5Hm3UTHqTW35NdW-7UMv1YtMtD=mesXFN7=hP=u_h7m9g@mail.gmail.com>
On Saturday 24 October 2015 00:58:12 Amitoj Kaur Chawla wrote:
> On Sat, Oct 24, 2015 at 12:53 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Saturday 24 October 2015 00:39:22 Amitoj Kaur Chawla wrote:
> >> This patch replaces timeval with timespec64 as 32 bit 'struct timeval'
> >> will not give current time beyond 2038.
> >>
> >> The patch changes the code to use ktime_get_real_ts64() which returns
> >> a 'struct timespec64' instead of do_gettimeofday() which returns a
> >> 'struct timeval'
> >>
> >> This patch also alters the format strings in pr_info() for now.tv_sec
> >> and now.tv_nsec to incorporate 'long long' on 32 bit architectures and
> >> leading zeroes respectively.
> >>
> >> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> >> ---
> >
> > The patch looks correct, but I think that this time the format string
> > was actually ok already for the microsecond value. Just leave it at "%6.6ld"
> > and send it again with the maintainers on Cc.
> >
>
> Oh okay can I ask the reason that the change was required there but not here?
>
>
The other one was "%lu", which has no leading zeroes, while this one
was "%6.6ld", which does.
I keep getting confused by printf format strings and sometimes have
to try these out myself, but my understanding is that these all
behave the same way:
"%06ld"
"%.6ld"
"%6.6ld"
"%6.06ld"
Arnd
next prev parent reply other threads:[~2015-10-23 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 19:09 [PATCH] char: ipmi: ipmi_ssif: Replace timeval with timespec64 Amitoj Kaur Chawla
2015-10-23 19:23 ` [Y2038] " Arnd Bergmann
2015-10-23 19:28 ` Amitoj Kaur Chawla
2015-10-23 19:34 ` Arnd Bergmann [this message]
2015-10-23 19:42 ` [Outreachy kernel] " Amitoj Kaur Chawla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3885032.B7rTY3eIDR@wuerfel \
--to=arnd@arndb.de \
--cc=amitoj1606@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.