From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Vladimir Medvedkin <medvedkinv@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] Make the thash library arch-independent
Date: Tue, 28 Jul 2015 18:05:26 +0200 [thread overview]
Message-ID: <3885263.OLndnQdN2M@xps13> (raw)
In-Reply-To: <CANDrEHnA8DP5wRbeAp-E+hTMieLb8=_xOWjB5A74Na+DG0jhCg@mail.gmail.com>
2015-07-28 18:33, Vladimir Medvedkin:
> 2015-07-28 16:47 GMT+03:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> > 2015-07-28 09:06, Vladimir Medvedkin:
> > Please explain how it was broken and how you fixed it.
> > It would be interesting to know which part is __SSE3__ and __SSE__.
> >
> As mentioned in http://dpdk.org/ml/archives/dev/2015-July/022020.html
> compilation fails on non x86 architectures( in that case it was tile). So I
> add for optimized code, which uses SSE3 intrinsics, non optimized general
> version.
I know. I was requesting an updated commit with explanations:
build is broken because...
x86 version uses SSE3...
Some code is enclosed with __SSE__, not __SSE3__ because...
What happens if it is built with SSE3 support but run on
a CPU without such support?
Please check how it is done for ACL.
> > > +#ifdef __SSE3__
> > > +#include <rte_vect.h>
> > > +#endif /* __SSE3__ */
> >
> > Comments after short ifdef block are not needed.
> >
> Should I delete it?
Yes please.
> > > +#ifndef XMM_SIZE
> > > +#define XMM_SIZE 16
> >
> > Why is it needed?
> >
> because there is no defines for XMM_SIZE on non X86 architectures
Why XMM_SIZE is needed on non x86 arch?
next prev parent reply other threads:[~2015-07-28 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 13:06 [PATCH] Make the thash library arch-independent Vladimir Medvedkin
2015-07-28 13:47 ` Thomas Monjalon
2015-07-28 15:33 ` Vladimir Medvedkin
2015-07-28 16:05 ` Thomas Monjalon [this message]
2015-07-28 19:08 ` Vladimir Medvedkin
2015-07-29 13:56 ` [PATCH v2] " Vladimir Medvedkin
2015-07-29 23:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3885263.OLndnQdN2M@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=medvedkinv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.