From: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Yuvaraj Kumar C D <yuvaraj.cd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
Yuvaraj Kumar C D
<yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: Update arch timer node with clock frequency
Date: Sat, 21 Sep 2013 17:24:59 +0200 [thread overview]
Message-ID: <3887347.Oxs1qQnt5k@flatron> (raw)
In-Reply-To: <1379499113-20342-1-git-send-email-yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Hi Yuvaraj,
On Wednesday 18 of September 2013 15:41:53 Yuvaraj Kumar C D wrote:
> Without the "clock-frequency" property in arch timer node, could able
> to see the below crash dump.
[snip]
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi index 7d7cc77..668ce5d 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -96,6 +96,7 @@
> <1 14 0xf08>,
> <1 11 0xf08>,
> <1 10 0xf08>;
> + clock-frequency = <24000000>;
Shouldn't it rather come from some clock provided by some clock controller
instead?
The frequency would be then retrieved using clk_get_rate() on a clock
received by clk_get(), specified in device tree using generic clock
bindings.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-21 15:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 10:11 [PATCH] ARM: dts: Update arch timer node with clock frequency Yuvaraj Kumar C D
[not found] ` <1379499113-20342-1-git-send-email-yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-18 10:23 ` Mark Rutland
2013-09-18 10:23 ` Mark Rutland
2013-09-20 4:57 ` Yuvaraj Kumar
2013-09-20 4:57 ` Yuvaraj Kumar
[not found] ` <CAKuRcOLfRwJohWMhc=QMew87SXtBmkPUJwW7UzNry_gFuC-81Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-20 8:17 ` Marc Zyngier
2013-09-20 8:17 ` Marc Zyngier
[not found] ` <523C048C.10303-5wv7dgnIgG8@public.gmane.org>
2013-09-20 14:55 ` Christopher Covington
2013-09-20 14:55 ` Christopher Covington
[not found] ` <523C61CB.2050607-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-09-20 15:04 ` Marc Zyngier
2013-09-20 15:04 ` Marc Zyngier
2013-09-21 15:24 ` Tomasz Figa [this message]
2013-09-23 14:15 ` Mark Rutland
2013-10-08 22:15 ` Olof Johansson
2013-10-09 8:25 ` Mark Rutland
2013-10-09 19:46 ` Olof Johansson
2013-10-09 21:51 ` Mark Rutland
2013-10-09 21:48 ` Rob Herring
2013-10-12 22:26 ` Olof Johansson
2013-10-12 22:31 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3887347.Oxs1qQnt5k@flatron \
--to=tomasz.figa-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=yuvaraj.cd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=yuvaraj.cd-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.